Closed Bug 139606 Opened 23 years ago Closed 15 years ago

Properties button in toolbar only enabled during download

Categories

(SeaMonkey :: Download & File Handling, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 474620

People

(Reporter: bugzilla, Unassigned)

References

Details

(Keywords: relnote, Whiteboard: [adt3] [UI])

when the dl mgr first landed, the Properties button in its toolbar wasn't hooked up... i cannot seem to find an existing bug for this, so am filing this one. seems like Properties is *always* disabled. is this gonna be hooked up any time soon? or, should we just remove it?
Keywords: nsbeta1
recently tested using 2002.04.22.0x-1.0.0 commercial branch bits.
works for me in 4/23 comm nightly 1.0, for items that are currently downloading...
Nav triage team: nsbeta1+, adt2
Keywords: nsbeta1nsbeta1+
Whiteboard: [adt2]
need more info...
blake, does this work for you? because i don't think i've ever seen Properties enabled on any platform... or, does Properties only become enabled during certain cases, eg, when the file is in the process of being downloaded, or finished downloading? (it hasn't worked for me with the latter, which would be the most common case, methinks.)
i did more poking around (using today's branch bits), and it looks like Properties is a. only enabled *while* the file is being downloaded. it's not enabled after download has completed. i re-read ben's spec, and couldn't find info as to whether that's expected. (am guessing my slower connection at home is allowing me to see this more easily than from the office.) b. clicking on it currently just brings the regular download progress dialog to the front. is that expected? is (a) expected? why shouldn't this be enabled after download is completed? should this be given to marlon/lori for recommendations? feel free to downgrade as needed...
Summary: Properties button in toolbar always seems disabled → Properties button in toolbar only enabled during download
It only works for items that are currently downloading, because it shows a progress dialog. This will change in the future but I think that's ok for rtm.
Summary: Properties button in toolbar only enabled during download → Properties button in toolbar always seems disabled
<collided with you> Yes, b is expected, but wouldn't normally happen once download manager appears by default. a is not ideal behavior, but okay for now.
okidoke --i'll let lori / marlon / adt reconsider whether (a) should be fixed soon. resummarizing to clarify the actual issue am seeing.
Keywords: nsbeta1+nsbeta1, relnote
Summary: Properties button in toolbar always seems disabled → Properties button in toolbar only enabled during download
nsbeta1- per Nav triage team.
Keywords: nsbeta1nsbeta1-
Target Milestone: --- → mozilla1.2alpha
Note, when you press properties, and the download progress window comes up, there is no way to get rid of this window, without canceling the download. This is definatly not helpful.
Properties button should be enabled for downloads that were not finished for whatever reason (interrupted by crash of mozilla, system shutdown, etc.). Or at least there should be some way to get address of download. In the ideal world "reload/ continue downloading" would be VERY helpfull.
nominating.
Keywords: nsbeta1-nsbeta1
Nav triage team: nsbeta1+/adt3
Keywords: nsbeta1nsbeta1+
Whiteboard: [adt2] → [adt3]
QA Contact: sairuh → petersen
Over to Jan.
Assignee: blaker → varga
Depends on: 189301
This issue is still occuring the Mach-0 (2003-01-23-07), OS 9 classic (2003-01-22-13), and Win32 (2003-01-24-08) trunks builds.
The behavior described in comment #11 is very annoying, FYI.
Target Milestone: mozilla1.2alpha → M1
Priority: -- → P3
Target Milestone: M1 → mozilla1.4beta
Whiteboard: [adt3] → [adt3] [UI]
*** Bug 202746 has been marked as a duplicate of this bug. ***
*** Bug 207965 has been marked as a duplicate of this bug. ***
Mozilla 1.3.1. I wanted to "remove the downloaded" files from the list. Ctrl A, remove from List, didn't work. I arrived to delete the single lines. But a few entries are not deletable... don't know how to get rid of them. P. Ogay
Product: Browser → Seamonkey
*** Bug 315270 has been marked as a duplicate of this bug. ***
The chrome change is easy mozilla/chrome/comm.jar/components/communicator/downloadmanager/downloadmanger.js line 182 - remove && isDownloading http://bonsai.mozilla.org/rview.cgi?dir=mozilla/browser/components/downloads/src/Attic&cvsroot=/cvsroot&module=default line 238 looks wrong - remove both lines, perhaps move them to RemoveDownload(&Path).
Assignee: Jan.Varga → nobody
Priority: P3 → --
QA Contact: chrispetersen → download-manager
Target Milestone: mozilla1.4beta → ---
The button is gone in the new download manager UI we have from SeaMonkey 2.0 Beta 1 upwards, but bug 474620 re-implements "properties" as a context and main menu item on the download manager and fixes this issue in being able to display the progress window for them even if the download is not active any more.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.