Closed
Bug 1396060
Opened 7 years ago
Closed 7 years ago
Update Screenshots to version 18.0.0
Categories
(Firefox :: Screenshots, enhancement)
Firefox
Screenshots
Tracking
()
RESOLVED
INVALID
People
(Reporter: ianbicking, Unassigned)
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
Details |
Changelog in https://github.com/mozilla-services/screenshots/blob/master/CHANGELOG.md#add-on-changes
* Run all add-on svg files through svgo (https://github.com/mozilla-services/screenshots/commit/40b9fe0)
* Fix icon appearance for Photon page action. See Bug 1395284]. Right now, the icon is too dark, so it doesn't match the appearance of the other Photon page actions. The problem is that the URI passed as the action's iconURL is a `file://` URI. The Photon theme uses context-fill and context-fill-opacity in SVG in order to style SVG icons correctly, and SVG context painting is not supported for file `bootstrap.js` should pass a `moz-extension://` URI instead, which context painting does support, and which is what the WebExtension browser action toolbar button uses. Additionally, the icon SVG used by the Photon page action needs to be updated with fill-opacity="context-fill-opacity". (https://github.com/mozilla-services/screenshots/commit/b246cb9)
* Add logging of unexpected clipboard state (https://github.com/mozilla-services/screenshots/issues/3430). This logs cases when the passed-in text is empty, or the textarea select doesn't appear to work. Logs are sent to Sentry. Fixes https://github.com/mozilla-services/screenshots/issues/3406 (https://github.com/mozilla-services/screenshots/commit/10b7c0f)
* Fixed next and prev buttons for rtl (https://github.com/mozilla-services/screenshots/commit/5a08464)
* Moved Save/Cancel buttons from right to left for rtl languages (https://github.com/mozilla-services/screenshots/issues/3412) (https://github.com/mozilla-services/screenshots/commit/115d6ed)
Reporter | ||
Comment 1•7 years ago
|
||
Another change I missed because it was part of the add-on and server:
* Send image to server in binary (https://github.com/mozilla-services/screenshots/commit/9c558ce)
Also note some eslint rules have been temporarily disabled because of problems with the Mozilla eslint plugin that caused persistent failures in CI. We'll be turning them back on soon.
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•7 years ago
|
||
I have started to test the provided Nightly try build with Screenshots 18.0.0 and I have found a critical issue. The shots are not correctly saved and the image is not displayed. Also, the shots are not displayed on "My Shots" page, the page is empty. I have logged this issue on Screenshots repository from GitHub: https://github.com/mozilla-services/screenshots/issues/3461
This issue should be fixed before uplifting Screenshots 18.0.0 in Nightly.
Reporter | ||
Comment 5•7 years ago
|
||
Because of the upload problem I'm going to retract this export and try again in another export/version.
Updated•7 years ago
|
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•