Closed Bug 1396240 Opened 7 years ago Closed 7 years ago

accessibility and private browsing indicators overlap the edge of the window on Windows 7

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
Unspecified
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 + fixed

People

(Reporter: jimm, Assigned: yzen)

References

Details

Attachments

(2 files)

indicators.jpg
(deleted), image/jpeg
Details
Private browing sign and fullscreen button on OS X 10.9
(deleted), image/png
Details
Attached image indicators.jpg (deleted) —
See screenshot
OS: Unspecified → Windows 7
From the looks of it, the title bar is less than 24px. Will need to confirm, but adding Amy with ni? to see what we can do on Win7.
Flags: needinfo?(amlee)
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
(In reply to Yura Zenevich [:yzen] from comment #1) > From the looks of it, the title bar is less than 24px. Will need to confirm, > but adding Amy with ni? to see what we can do on Win7. Can we move the icons in to the tab bar under it?
Flags: needinfo?(amlee)
(In reply to Amy Lee [:amylee] UX from comment #2) > (In reply to Yura Zenevich [:yzen] from comment #1) > > From the looks of it, the title bar is less than 24px. Will need to confirm, > > but adding Amy with ni? to see what we can do on Win7. > > Can we move the icons in to the tab bar under it? I think this is possible, I'll take care of it then.
Fixed by backout.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
After this bug got fixed and sign went back, I could see that the fullscreen button appear to be a lot lower than it should (it's actually lower than in normal windows), hence not vertically centered on the bar. See the joined screenshot to have an overview. In the meantime, private browsing sign and fullscreen button now looks very very close, is this normal? Same question for the private browing sign that takes the full height on compact density while it wasn't before if I remember correctly. Screenshot was taken on OS X 10.9.
Flags: needinfo?(yzenevich)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
oops wrong bug sorry
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Flags: needinfo?(yzenevich)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: