Closed
Bug 1396407
Opened 7 years ago
Closed 7 years ago
[lint] Settings follow-up: setView does not support all versions
Categories
(Firefox for Android Graveyard :: General, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: liuche, Assigned: liuche)
References
Details
(Whiteboard: [MobileAS])
Attachments
(1 file)
Fix lint errors from bug 1386735 - inflate layout instead of using resource id directly, to support Android versions below r21.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → liuche
Iteration: --- → 1.29
Whiteboard: [MobileAS]
|
|
Assignee | |
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8904056 [details]
Bug 1396407 - [lint] Fix AlertDialog.Builder.setView call to support pre-r21.
https://reviewboard.mozilla.org/r/175800/#review180776
Quick linter fix - inflate resource instead of just passing in resid. r=trivial
Attachment #8904056 -
Flags: review?(liuche) → review+
Pushed by cliu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d3f96564e3e
[lint] Fix AlertDialog.Builder.setView call to support pre-r21. r=liuche
|
||
Comment 4•7 years ago
|
||
Thank you for the quick action. Unfortunately, the lint job is still failing: https://treeherder.mozilla.org/logviewer.html#?job_id=128119255&repo=autoland
Flags: needinfo?(liuche)
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
|
Assignee | |
Comment 6•7 years ago
|
||
Thanks Sebastian, I forgot to remove the line that was causing the lint failure - removed it in bug 1396589.
Flags: needinfo?(liuche)
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•