Closed
Bug 1396722
Opened 7 years ago
Closed 7 years ago
remove no-op ReleaseStyleContext()
Categories
(Core :: Widget: Gtk, enhancement)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
No description provided.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8904430 [details]
bug 1396722 remove no-op ReleaseStyleContext()
https://reviewboard.mozilla.org/r/176270/#review181772
The patch looks good but fails to apply to latest mozilla-central:
hg import https://reviewboard-hg.mozilla.org/gecko/rev/4b9fba657657b4575290da4967deb8833b07759d
applying https://reviewboard-hg.mozilla.org/gecko/rev/4b9fba657657b4575290da4967deb8833b07759d
patching file widget/gtk/nsLookAndFeel.cpp
Hunk #1 FAILED at 294
Hunk #2 FAILED at 388
Hunk #3 FAILED at 852
Hunk #4 FAILED at 931
4 out of 4 hunks FAILED -- saving rejects to file widget/gtk/nsLookAndFeel.cpp.rej
abort: patch failed to apply
Attachment #8904430 -
Flags: review?(stransky)
|
Assignee | |
Comment 3•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8904430 [details]
bug 1396722 remove no-op ReleaseStyleContext()
https://reviewboard.mozilla.org/r/176270/#review181772
Thank you for looking. The patch applies to m-c now that
https://hg.mozilla.org/mozilla-central/rev/e711937ff6fa
has been merged.
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8904430 -
Flags: review?(stransky)
|
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8904430 [details]
bug 1396722 remove no-op ReleaseStyleContext()
https://reviewboard.mozilla.org/r/176270/#review182470
Looks fine, Thanks.
Attachment #8904430 -
Flags: review?(stransky) → review+
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/f7475262b1cf
remove no-op ReleaseStyleContext() r=stransky+263117
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•