Closed
Bug 1396838
Opened 7 years ago
Closed 7 years ago
Drop WindowState
Categories
(Testing :: geckodriver, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(3 files)
It was agreed that the concept of window state would be dropped from
WebDriver L1.
We also agreed at the WebDriver WG work day on last Wednesday
that the appropriate return type for ElementRectResponse and
WindowRectResponse would be signed 32-bit integers because the
WebIDL for screenY/screenX/outerWidth/outerHeight mark them as
longs.
This means that whilst it is technically possible to set a window to
a decimal-point value, the serialised return value will always be a
long.
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
I will deal with the ElementRectResponse/WindowRectResponse
return types in a separate bug
https://bugzilla.mozilla.org/show_bug.cgi?id=1396866.
Summary: Drop WindowState and correct return types of ElementRectResponse → Drop WindowState
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8904591 -
Flags: review?(james)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8904591 [details]
Bug 1396838 - Drop WindowState.
https://reviewboard.mozilla.org/r/176430/#review181358
Attachment #8904591 -
Flags: review?(james) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8904617 [details]
Bug 1396838 - Set window rect before every test.
https://reviewboard.mozilla.org/r/176438/#review181362
Attachment #8904617 -
Flags: review?(james) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8904618 [details]
Bug 1396838 - Remove window state from wdpsec tests.
https://reviewboard.mozilla.org/r/176440/#review181364
Attachment #8904618 -
Flags: review?(james) → review+
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/354e76aa5821
Drop WindowState. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/3cc131aab5f4
Set window rect before every test. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/9eba75195a30
Remove window state from wdpsec tests. r=jgraham
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/354e76aa5821
https://hg.mozilla.org/mozilla-central/rev/3cc131aab5f4
https://hg.mozilla.org/mozilla-central/rev/9eba75195a30
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•