Closed
Bug 1396894
Opened 7 years ago
Closed 7 years ago
about:telemetry - Pings with Environment sections but no addons subsesction trigger the Raw JSON view due to TypeError
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: chutten, Assigned: chutten)
References
Details
Attachments
(1 file)
If a ping has environment data, EnvironmentData.render(ping) will render it. It will then use special rendering to render the Addon data.
If the Environment block doesn't have an Addon section (due to, among other things, delayed addon init) then it defaults to showing the Raw JSON of the ping.
With the new about:telemetry redesign, showing the Raw JSON involves opening a new tab to show it using Firefox's spiffy JSON viewer.
This is jarring and avoidable.
So, instead, _check_ that an addons subsection exists before rendering one.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8904675 -
Flags: review?(gfritzsche) → review?(alessio.placitelli)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8904675 [details]
bug 1396894 - Don't error out when rendering normally-structured pings
https://reviewboard.mozilla.org/r/176478/#review181840
Took me a bit to figure the "key" change :S Looks good!
Attachment #8904675 -
Flags: review?(alessio.placitelli) → review+
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/378fb9246039
Don't error out when rendering normally-structured pings r=Dexter
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•