Closed
Bug 1397121
Opened 7 years ago
Closed 7 years ago
Some of About: pages subdialog's and submenu's font size are too huge
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | verified |
People
(Reporter: rickychien, Assigned: rickychien)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [photon-preference])
Attachments
(3 files)
This is a regression from bug 1392532. Font size is too big in about:preferences#privacy sub-dialogs which causes layout broken. A follow-up patch is coming to fix this issue.
Flags: qe-verify+
Comment 2•7 years ago
|
||
Is it possible to have test? It'd be useful to make sure we don't break layout again somewhere in the future.
Flags: in-testsuite?
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
I think it's hard to set up automatic tests to ensure font-size or any potential visual regression. Visual changes can either be verified by manual testing from QA or UI review from designer. UI review is currently under process, we hope that we can catch any visual regression as early as possible.
Assignee | ||
Comment 7•7 years ago
|
||
Patch has verified on Win/Mac/Linux and now I'm sure that font-size issue has been fixed when testing under about:preferences sub-dialogs, about:config, about:telemetry, about:addons.
Updated•7 years ago
|
Flags: in-testsuite?
Comment 8•7 years ago
|
||
I have spotted this today and mozregression lead me up to this bug tree. Have you tested the gear button in about:addons, and the extension entry context menu? Also the extension headline in the extension preferences is in the size or regular text, not even in bold.
Comment 9•7 years ago
|
||
Updated•7 years ago
|
Whiteboard: [photon-preference][triage] → [photon-preference]
Updated•7 years ago
|
Blocks: 1392532
Has Regression Range: --- → yes
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox57:
--- → affected
status-firefox-esr52:
--- → unaffected
No longer depends on: 1392532
Keywords: regression
Summary: Some of Preferences subdialog's font size are too huge → Some of About: pages subdialog's and submenu's font size are too huge
Version: 55 Branch → 57 Branch
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8904894 [details] Bug 1397121 - Some of Preferences subdialog's font size are too huge https://reviewboard.mozilla.org/r/176674/#review181954 ::: toolkit/themes/linux/global/in-content/common.css:134 (Diff revision 3) > > *|*.category-name { > font-size: 1.19rem; > } > > -xul|caption > xul|label { > +xul|caption > xul|label:not([class="dialogTitle"]) { xul|caption > xul|label:not(.dialogTitle) ::: toolkit/themes/osx/global/in-content/common.css:146 (Diff revision 3) > > *|*.category-name { > font-size: 1.45rem; > } > > -xul|caption > xul|label { > +xul|caption > xul|label:not([class="dialogTitle"]) { xul|caption > xul|label:not(.dialogTitle) ::: toolkit/themes/windows/global/in-content/common.css:95 (Diff revision 3) > > *|*.category-name { > font-size: 1.33rem; > } > > -xul|caption > xul|label { > +xul|caption > xul|label:not([class="dialogTitle"]) { xul|caption > xul|label:not(.dialogTitle)
Attachment #8904894 -
Flags: review?(jaws) → review+
Comment hidden (mozreview-request) |
Comment 13•7 years ago
|
||
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4d8100bcbc1 Some of Preferences subdialog's font size are too huge r=jaws
Comment 14•7 years ago
|
||
Don't know if its intentional - but Yeah ! the font in about:config is too big, as is about:support had filed a bug 1397352
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c4d8100bcbc1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 16•7 years ago
|
||
FYI... Context menus still have oversized fonts such as on about:downloads. Also, the gear icon on about:addons has the same large font. I'm on inbound which has this patch.
Comment 18•7 years ago
|
||
Assignee | ||
Comment 19•7 years ago
|
||
Hey Gary, large font issue on context menu is addressing in bug 1397325.
Flags: needinfo?(rchien)
Comment 20•7 years ago
|
||
Is there also a bug for the titles in about:addons? Comment #8 and comment #9.
Flags: needinfo?(rchien)
Comment 21•7 years ago
|
||
The headline/title of about:support is not styled and displayed as the page description below.
Assignee | ||
Comment 22•7 years ago
|
||
The headline/title of about:support issue is supposed to be addressed in bug 1397325. I can try to apply the patch to see if it fixes the issue you saw.
Flags: needinfo?(rchien)
Comment 23•7 years ago
|
||
Build ID: 20170910220126 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64 since large font issue on context menu, the gear icon on about:addons large font and the headline/title of about:support issues will be addressed in bug 1397325.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•