Closed
Bug 1397894
Opened 7 years ago
Closed 7 years ago
Custom tabs: fix loading pages
Categories
(GeckoView :: General, enhancement, P1)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: esawin, Assigned: esawin)
References
Details
Attachments
(1 file)
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
In bug 1396065 we've extended GeckoView to support general URI load delegation but failed to update the onLoadUri callback for custom tabs to account for that.
Assignee | ||
Comment 1•7 years ago
|
||
Fire the generic view intent for external links and let Gecko handle the load otherwise.
We might want to extent the intent-based handling to links outside of the current domain.
Attachment #8905658 -
Flags: review?(snorp)
Assignee | ||
Comment 2•7 years ago
|
||
s/extent/extend
Attachment #8905658 -
Flags: review?(snorp) → review+
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83d8880fbf0e
[1.0] Fix GeckoView custom tabs URI loading. r=snorp
Updated•7 years ago
|
Priority: -- → P1
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•6 years ago
|
Product: Firefox for Android → GeckoView
Updated•6 years ago
|
Target Milestone: Firefox 57 → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•