Closed
Bug 1398033
Opened 7 years ago
Closed 7 years ago
Free dirty pages on memory pressure
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8905795 [details]
Bug 1398033 - Free dirty pages on memory pressure.
https://reviewboard.mozilla.org/r/177600/#review182652
Do you have any sample measurements before and after?
Attachment #8905795 -
Flags: review?(n.nethercote) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Before:
https://queue.taskcluster.net/v1/task/MGoinDX7TUmKKWIobBFYbA/runs/0/artifacts/public/test_info//memory-report-TabsOpenForceGC-2.json.gz
After:
https://queue.taskcluster.net/v1/task/clGKH6KpRRK_7irs8-lXYA/runs/0/artifacts/public/test_info//memory-report-TabsOpenForceGC-2.json.gz
That does get us closer to 0 on page-cache, although not really 0. There could be a timing problem with jemalloc_free_dirty_pages being dispatched to the main thread (on top of other things happening in other threads).
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/d212f4ad3166
Free dirty pages on memory pressure. r=njn
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•