Jeff Beatty [:gueroJeff] Reporter
	Description • 7 years ago

What is happening:

Space for each pinned tab is crowding and overlapping their neighboring pinned tabs. 

This is on today's Nightly, 57.0a1 (2017-09-08) (64-bit), on Mac OS.

What is expected:

Pinned tabs should maintain boundaries that respect the space of their neighboring pinned tabs and not display those boundaries over pinned tab icons.

Steps to reproduce:

1) Switch to the light theme.
2) Pin three or more tabs to the tab bar (?).
3) Hover over each pinned tab to see the crowding and overlaps.

	:Gijs (he/him)
	Comment 1 • 7 years ago

Works for me. Can you reproduce in a clean profile? Any add-ons in this profile? Does it matter which tabs you pin? Do you maybe need more than 3 to reproduce?

	Jeff Beatty [:gueroJeff] Reporter
	Comment 2 • 7 years ago

I haven't been able to reproduce. Seems to have been fixed. Thanks

	:Gijs (he/him)
	Comment 3 • 7 years ago

Resolving per comment #2.

	Kestrel
	Comment 4 • 7 years ago

Today I restored a session consisting of two windows that had only recently been upgraded to 57 for the first time and the first window's pinned tabs were overlapping. #tabbrowser-tab margin-inline-start only gave room for 24px wide pinned tabs when it should have been 40px. I have been unable to reproduce it after further restarts.

	:Gijs (he/him)
	Comment 5 • 7 years ago

(In reply to Kestrel from comment #4)
> Created attachment 8910702 [details]
> pinned-tabs-squashed.png
> 
> Today I restored a session consisting of two windows that had only recently
> been upgraded to 57 for the first time and the first window's pinned tabs
> were overlapping. #tabbrowser-tab margin-inline-start only gave room for
> 24px wide pinned tabs when it should have been 40px. I have been unable to
> reproduce it after further restarts.

Feels like there's a race condition here. Maybe folks on the visual team who know about this bit of the tabstrip implementation have some idea of how to move forward here.

	Dão Gottwald [:dao] Assignee
	Comment 6 • 7 years ago

[Tracking Requested - why for this release]:

Proactively requesting tracking, but I'm afraid we'll need more information -- steps to reproduce or a regression range -- for this bug to be actionable.

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 7 • 7 years ago

Tracked for 57 for now, beta57 will be at 100% starting today, let's wait see whether this is a widespread issue or not.

	Kestrel
	Comment 8 • 7 years ago

Seems to be quite a rare bug, I have been able to reproduce it a few times but without a reliable STR. 

It only happens when:
1. Upgrading a profile from FF56 to FF57 for the first time.
2. Session has more than one window.
3. First window has pinned tabs and an overflowing tab strip.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 9 • 7 years ago

Andrei, can your team have a look to try to reproduce with Kestrel's suggestions in comment 8? Thanks.

	Oana Botisan, Desktop QA
	Comment 10 • 7 years ago

I tried to reproduce this bug using Windows 10x64, Ubuntu 16.04x64 and Mac OS 10.11. 

I used two methods:

  1. Update from beta 56 to beta 57.
  2. Update from Nightly 56 to Nightly 58 (unfortunately I couldn't stop the update at 57, so I am not sure if the result from this method is relevant).

In both cases I used the default and the light theme, but I couldn't reproduce it. The tabs I pinned remained the same. They weren't overlapping. 

Did I miss something?

	Dão Gottwald [:dao] Assignee
	Comment 12 • 7 years ago

I believe bug 1392157 regressed this.

	Jared Wein [:jaws] (please needinfo? me)
	Comment 14 • 7 years ago
mozreview-review

Comment on attachment 8920544 [details]
Bug 1398142 - Always specify .tab-throbber size so that pinned tabs can be positioned correctly before the session has been restored.

https://reviewboard.mozilla.org/r/191550/#review197250

	Pulsebot
	Comment 15 • 7 years ago

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/609a1d5781e2
Always specify .tab-throbber size so that pinned tabs can be positioned correctly before the session has been restored. r=jaws

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 16 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/609a1d5781e2

	Dão Gottwald [:dao] Assignee
	Comment 17 • 7 years ago

Comment on attachment 8920544 [details]
Bug 1398142 - Always specify .tab-throbber size so that pinned tabs can be positioned correctly before the session has been restored.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1392157
[User impact if declined]: see comment 0
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple fix
[String changes made/needed]: /

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 18 • 7 years ago

Comment on attachment 8920544 [details]
Bug 1398142 - Always specify .tab-throbber size so that pinned tabs can be positioned correctly before the session has been restored.

Low risk fix, the squished pinned tabs look bad, fixing it seems like a good idea,  Beta57+

	Ryan VanderMeulen [:RyanVM]
	Comment 19 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/c8c16ef5be63