Closed
Bug 1398223
Opened 7 years ago
Closed 7 years ago
Test annotations for Quantum Render
Categories
(Testing :: General, enhancement)
Testing
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: gbrown, Assigned: kats)
References
Details
Attachments
(1 file)
mozinfo knows about "asan" and "stylo", but I do not see any allowance made for Quantum Render. When a test fails only on, say, linux64-qr, is there a way to skip the test only on that test platform?
Reporter | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #1)
> https://bugzilla.mozilla.org/show_bug.cgi?id=1380971#c15
The discussion in that bug is about reftests. mozinfo doesn't apply to reftests.
Reporter | ||
Comment 3•7 years ago
|
||
I'm happy to see "webrender" in the reftest sandbox, and that absolutely addresses my primary concern - thanks!
If there is also the possibility of a qr-specific failure in a mochitest or other test suite, we should have a similar way of annotating tests in those suites.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bugmail
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
BTW the try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e7703ae5033c250baaf47aeba707e2b0038927d includes this patch, as well as a patch that uses "skip-if = webrender" on the test in gfx/tests/chrome/chrome.ini. It seems to work fine - the M-e10s(gpu) job for linux64 still runs the test, but the corresponding QuantumRender job skips the test. I also tested locally with `MOZ_WEBRENDER=1 ./mach test ...` and got similar results which is good.
Reporter | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8910456 [details]
Bug 1398223 - Add a webrender flag to mozinfo to allow using it in mochitest.ini conditions.
https://reviewboard.mozilla.org/r/181898/#review187276
Looks good - thanks!
Attachment #8910456 -
Flags: review?(gbrown) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36d6f521c2b2
Add a webrender flag to mozinfo to allow using it in mochitest.ini conditions. r=gbrown
Comment 9•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•