currently mochitest-media has 1 failure which is documented in bug 1398139. I have verified with that one test skipped we can get to green. The assumption is that will be fixed soon and we can move forward, in the event it isn't fixed by EOD September 12th, I will want to land with that skipped so we can ensure a smooth transition to win10 and reduce the risk of a new failure showing up.

this patch does it all, also disabling a test which hopefully will get fixed in the next couple days- otherwise I want to land this to avoid other tests breaking.

here is a try run showing a lot of green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5aa08f561e6d8e343b1e71f6f1b5a784650207d here is a fresh run with just this patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4b3a40e56659ea455cc17988d02b916bc13d9b7

Comment on attachment 8906044 [details] [diff] [review] run mochitest-media on windows10 instead of windows8 Review of attachment 8906044 [details] [diff] [review]: ----------------------------------------------------------------- Yep LGTM R+ assuming latest try run is green ::: dom/media/mediasource/test/mochitest.ini @@ +158,5 @@ > skip-if = ((os == "win" && os_version == "5.1") || (toolkit == 'android')) # Not supported on xp and android 2.3 > [test_WaitingOnMissingDataEnded_mp4.html] > skip-if = ((os == "win" && os_version == "5.1") || (toolkit == 'android')) # Not supported on xp and android 2.3 > [test_WaitingToEndedTransition_mp4.html] > +skip-if = ((os == "win" && os_version >= "10.0") || (toolkit == 'android')) # Not supported on xp and android 2.3 Nit: Win 10 (not xp)

Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6cf33147c7e3 run mochitest-media on windows 10 instead of windows 8. r=rwood

After fixing bug1398139, should we re-enable mochitest-media on Win8? Thanks!

we currently run mochitest-media on windows10, not windows 8 :) Ideally the test fix should remove the windows 10 condition in the mochitest.ini file: http://searchfox.org/mozilla-central/source/dom/media/mediasource/test/mochitest.ini#162 ^ note: searchfox is not reflecting the current tip of mozilla-central when I am writing this comment

(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #7) > we currently run mochitest-media on windows10, not windows 8 :) Ideally the > test fix should remove the windows 10 condition in the mochitest.ini file: > http://searchfox.org/mozilla-central/source/dom/media/mediasource/test/ > mochitest.ini#162 > > ^ note: searchfox is not reflecting the current tip of mozilla-central when > I am writing this comment OK! Thank you very much :)