Closed
Bug 1398542
Opened 7 years ago
Closed 6 years ago
Need test coverage for video and audio types in contextMenus / menus API
Categories
(WebExtensions :: General, defect, P5)
Tracking
(firefox63 fixed)
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: robwu, Assigned: robwu)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I discovered that there is no test coverage for the OnClickData properties for the "audio" and "video" context types in the contextMenus / menus API.
The full list of context types is at:
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/menus/ContextType
The following two files provide some test coverage for most of the types, except "audio" and "video":
https://searchfox.org/mozilla-central/rev/d29c832536839b60a9ee5b512eeb934274b879b0/browser/components/extensions/test/browser/browser_ext_contextMenus.js
page
link
selection
image
editable
password
https://searchfox.org/mozilla-central/rev/d29c832536839b60a9ee5b512eeb934274b879b0/browser/components/extensions/test/browser/browser_ext_menus.js
page_action
browser_action
tab
page
frame
tools_menu
Updated•7 years ago
|
Priority: -- → P5
Updated•6 years ago
|
Product: Toolkit → WebExtensions
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → rob
Blocks: 1466876
Status: NEW → ASSIGNED
Iteration: --- → 63.2 - July 23
status-firefox57:
wontfix → ---
Assignee | ||
Updated•6 years ago
|
Iteration: 63.2 - July 23 → 63.3 - Aug 6
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
Note: The added test may increase the odds of triggering the timeout threshold, bug 1469836.
I'll monitor that other bug to see if additional action is necessary.
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8996752 [details]
Bug 1398542 - Add test coverage for video/audio context menus
https://reviewboard.mozilla.org/r/260802/#review268008
Attachment #8996752 -
Flags: review?(mixedpuppy) → review+
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/65b6a2ecc111
Add test coverage for video/audio context menus r=mixedpuppy
Assignee | ||
Updated•6 years ago
|
Flags: qe-verify-
Comment 7•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•