Closed Bug 1398606 Opened 7 years ago Closed 7 years ago

Update browser-style to follow Photon style guide

Categories

(WebExtensions :: Frontend, enhancement, P3)

57 Branch
Unspecified
Windows 7
enhancement

Tracking

(firefox57 fix-optional)

RESOLVED DUPLICATE of bug 1421652
Tracking Status
firefox57 --- fix-optional

People

(Reporter: wip.the.gruik, Unassigned)

Details

Attachments

(1 file)

The stylesheet associated to the *browser_style* property of WebExtensions add-ons should be updated to follow Photon guidelines. Reference: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/user_interface/Browser_styles
Component: Untriaged → WebExtensions: General
Product: Firefox → Toolkit
Component: WebExtensions: General → WebExtensions: Frontend
Flags: needinfo?(mjaritz)
Flags: needinfo?(bwinton)
Yeah, I think it should. Of course, Markus is the official UX person for this feature, so you should go with what he says if he disagrees. :) (But I think he's on PTO this week, maybe?) I would actually go a step further, and suggest we as the people implementing the re-design of addons.mozilla.org to update this stylesheet, so that it can be a copy of the one we use for the in-content pages (like about:addons).
Flags: needinfo?(bwinton)
(In reply to Blake Winton (:bwinton) (:☕️) from comment #1) > I would actually go a step further, and suggest we as the people > implementing the re-design of addons.mozilla.org to update this stylesheet, > so that it can be a copy of the one we use for the in-content pages (like > about:addons). Which "we" is this, exactly? :)
Priority: -- → P3
Summary: WebExtensions - update browser-style to follow Photon style guide → Update browser-style to follow Photon style guide
Yes, it should be updated. Or better, somehow linked to the styles we use on inproduct pages like about:preferences. (In reply to Blake Winton (:bwinton) (:☕️) from comment #1) > I would actually go a step further, and > suggest we as the people implementing the re-design of addons.mozilla.org to > update this stylesheet, so that it can be a copy of the one we use for the > in-content pages (like about:addons). I am not sure I understand your proposal. The options have more in common with about:preferences and about:addons than addons.mozilla.org
Flags: needinfo?(mjaritz)
I took a (very!) quick look at this since I'm having issues with the existing browser-style CSS. I doubt we'd be able to just use the styles from about:preferences, since that's XUL, but I'm sure we could simplify some parts of the current browser-styles (especially checkboxes and radio buttons). Since I'm probably going to have to roll some of my own CSS anyway, I'd be happy to look into this, provided there's no great urgency on it. :) One question: how much should we try to remain API-compatible with the existing browser-style? I'm guessing we should do our best to remain compatible, but would it be worth adding simpler versions of the styles where possible as well? (In particular, I'm thinking of how checkboxes and radio buttons currently require the developer to put a <label> immediately after the <input>.)
Depends on: 1371951
No longer depends on: 1371951
Duplicate of bug 1421652, because the actual update of the stylesheet to the Photon style is being done in that bug.
Flags: needinfo?(ntim.bugs)
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Flags: needinfo?(ntim.bugs)
Resolution: --- → DUPLICATE
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: