Closed
Bug 1398671
Opened 7 years ago
Closed 7 years ago
Call AsyncAbort when a tail request is canceled
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | + | fixed |
People
(Reporter: kershaw, Assigned: kershaw)
References
Details
(Keywords: memory-leak, regression)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
kershaw
:
review+
|
Details | Diff | Splinter Review |
When a tail request is canceled at [1], we have to call AsyncAbort to avoid memory leaks.
[1] http://searchfox.org/mozilla-central/rev/00fa5dacedb925022f53d025121f1a919508e7ce/netwerk/protocol/http/nsHttpChannel.cpp#6021-6023
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8906479 -
Flags: review?(hurley)
Comment on attachment 8906479 [details] [diff] [review]
Call AsyncAbort when canceling a tail request
Review of attachment 8906479 [details] [diff] [review]:
-----------------------------------------------------------------
Your commit message (or a comment in the code or, ideally, both) needs to explain *why* this is the right thing to do, not just what's happening (which is fairly obvious from reading the code).
Attachment #8906479 -
Flags: review?(hurley) → review-
Assignee | ||
Comment 3•7 years ago
|
||
Only commit message is changed.
Thanks.
Attachment #8906479 -
Attachment is obsolete: true
Attachment #8906853 -
Flags: review?(hurley)
Attachment #8906853 -
Flags: review?(hurley) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Carry r+.
Attachment #8906853 -
Attachment is obsolete: true
Attachment #8907130 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8d001a6ee41
Call AsyncAbort when canceling a tail request. r=hurley
Keywords: checkin-needed
Comment 7•7 years ago
|
||
[Tracking Requested - why for this release]: This fixes a really bad leak seen on at least one real website (see bug 1397062).
tracking-firefox57:
--- → ?
Keywords: mlk,
regression
Comment 8•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Comment 9•7 years ago
|
||
A bit better solution would be when CancelTailedRequest called back (aRequest->OnTailUnblock) with an error.
You need to log in
before you can comment on or make changes to this bug.
Description
•