Closed
Bug 1398985
Opened 7 years ago
Closed 7 years ago
21,300 instances of "We've already scheduled a task for background list flush." emitted from parser/html/nsHtml5TreeOpExecutor.cpp during linux64 debug testing
Categories
(Core :: DOM: HTML Parser, defect, P2)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: erahm, Assigned: alchen)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
alchen
:
review+
|
Details | Diff | Splinter Review |
> 21346 WARNING: We've already scheduled a task for background list flush.: file parser/html/nsHtml5TreeOpExecutor.cpp, line 283
This warning [1] shows up in the following test suites:
> 2606 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
> 1017 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
> 960 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
> 945 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
> 899 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
> 872 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
> 862 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
> 862 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
> 818 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
> 783 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
> 751 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
> 736 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
> 725 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
> 594 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
> 576 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
> 546 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
> 495 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
> 490 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
> 373 - test-linux64/debug-mochitest-e10s-3 3
> 364 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
> 358 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
> 327 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
> 313 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
> 290 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
> 275 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
> 266 - test-linux64/debug-mochitest-e10s-5 5
> 262 - test-linux64/debug-mochitest-clipboard-e10s cl
> 220 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
> 211 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
> 204 - test-linux64/debug-test-verify-e10s TV
> 196 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
> 192 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
> 178 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
> 174 - test-linux64/debug-marionette-e10s Mn
> 129 - test-linux64/debug-web-platform-tests-wdspec-e10s Wd
> 126 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
> 117 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
> 102 - test-linux64/debug-mochitest-e10s-10 10
> 99 - test-linux64/debug-mochitest-e10s-7 7
> 98 - test-linux64/debug-marionette-headless-e10s MnH
> 90 - test-linux64/debug-mochitest-e10s-1 1
> 84 - test-linux64/debug-mochitest-e10s-9 9
> 84 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
> 71 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
> 70 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
> 61 - test-linux64/debug-mochitest-chrome-1 c1
> 60 - test-linux64/debug-mochitest-e10s-8 8
> 59 - test-linux64/debug-mochitest-e10s-6 6
> 56 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
> 42 - test-linux64/debug-mochitest-e10s-2 2
> 42 - test-linux64/debug-mochitest-a11y a11y
> 31 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
> 28 - test-linux64/debug-telemetry-tests-client-e10s tc-e10s
> 28 - test-linux64/debug-mochitest-chrome-3 c3
> 28 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
> 17 - test-linux64/debug-mochitest-chrome-2 c2
> 14 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
> 14 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
> 14 - test-linux64/debug-mochitest-media-e10s-2 mda2
> 14 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
> 14 - test-linux64/debug-mochitest-media-e10s-3 mda3
> 14 - test-linux64/debug-mochitest-gpu-e10s gpu
It shows up in 2115 tests. A few of the most prevalent:
> 182 - [e10s] browser/components/sessionstore/test/browser_formdata_cc.js
> 173 - [e10s] browser/components/sessionstore/test/browser_819510_perwindowpb.js
> 166 - [e10s] docshell/test/test_bug598895.html
> 162 - [e10s] browser/components/sessionstore/test/browser_595601-restore_hidden.js
> 155 - [e10s] browser/components/sessionstore/test/browser_590268.js
> 150 - [e10s] browser/components/sessionstore/test/browser_windowStateContainer.js
> 140 - [e10s] dom/html/test/test_iframe_sandbox_navigation2.html
> 139 - [e10s] dom/tests/mochitest/bugs/test_bug260264.html
> 133 - [e10s] dom/tests/browser/browser_noopener.js
> 123 - [e10s] dom/html/test/test_iframe_sandbox_popups_inheritance.html
[1] https://hg.mozilla.org/mozilla-central/annotate/f9a5e9ed6210/parser/html/nsHtml5TreeOpExecutor.cpp#l283
Reporter | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Hi Alphan, could you please help us follow up comment 1 and get a regression window? Thank you.
Flags: needinfo?(alchen)
Priority: -- → P2
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → alchen
Flags: needinfo?(alchen)
Assignee | ||
Comment 3•7 years ago
|
||
The symptom should be related to the following commit.
https://hg.mozilla.org/mozilla-central/rev/c72349ea26d7
Bug 1355746 - Part 2. Polish IdleTaskRunner and reuse it for background parsing. r=smaug
This patch is mainly to make IdleTaskRunner reusable by nsHtml5TreeOpExecutor. The only necessary work to that purpose is to remove the dependency of sShuttingDown, which was a static variable in nsJSEnvironment.cpp. The idea is to have a "MayStopProcessing" as a callback for the consumer to return sShuttingDown.
Assignee | ||
Comment 4•7 years ago
|
||
After consulting with Henry Chang [:hchang], the warning message could be removed.
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8908491 -
Flags: review?(erahm)
Reporter | ||
Updated•7 years ago
|
Attachment #8908491 -
Attachment is patch: true
Reporter | ||
Comment 6•7 years ago
|
||
Comment on attachment 8908491 [details] [diff] [review]
Remove a warning message in nsHtml5TreeOpExecutor::ContinueInterruptedParsingAsync()
Review of attachment 8908491 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the fix!
Attachment #8908491 -
Flags: review?(erahm) → review+
Assignee | ||
Comment 7•7 years ago
|
||
Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9491d3ab295e1d867039b11f458c303f3677ac95
Attachment #8908491 -
Attachment is obsolete: true
Attachment #8911714 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66ed9c4a0997
Remove a warning message in nsHtml5TreeOpExecutor::ContinueInterruptedParsingAsync(). r=erahm
Keywords: checkin-needed
Comment 9•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•