In bug 1329154 we've added BrowserApp to the GeckoView window which breaks some modules that identify GeckoView windows by the absence of BrowserApp.

The windowtype should be a reliable way to detect GeckoView windows. Do we use this type of check anymore else?

Comment on attachment 8907650 [details] [diff] [review] 0001-Bug-1399518-1.0-Use-windowtype-to-detect-GeckoView-w.patch Review of attachment 8907650 [details] [diff] [review]: ----------------------------------------------------------------- What do you think about just checking for the feature? (e.g. `chromeWin.NativeWindow && chromeWin.NativeWindow.doorhanger`) So if we ever have a `NativeWindow.doorhanger` implementation for GeckoView we would use that automatically. ::: mobile/android/modules/Prompt.jsm @@ +23,5 @@ > .rootTreeItem.QueryInterface(Ci.nsIInterfaceRequestor) > .getInterface(Ci.nsIDOMWindow); > } > > +function isGeckoView(aWindow) { This feels a little backwards. I think it should be `isBrowserJS`, and we should compare against "navigator:browser".

Pushed by esawin@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3a35599c5d1e [1.1] Check for NativeWindow features to identify the window type for prompt handling. r=jchen