Closed
Bug 1399548
Opened 7 years ago
Closed 7 years ago
Prevent unnecessary updates in toolbox react components
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
toolbox-controller.js frames represent a quite significant part of processing for the toolbox loading.
This is due to too many updates for the component and its hiearchy.
https://perfht.ml/2eylj9K
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8907690 [details]
Bug 1399548 - Prevent updating toolbox react component until it is ready to be displayed.
https://reviewboard.mozilla.org/r/179352/#review184500
Attachment #8907690 -
Flags: review?(gtatum) → review+
|
Assignee | |
Comment 3•7 years ago
|
||
Green try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d223b985f81746880da0b1c6608fd0fa542297a
And for the record, DAMP reports 3 to 9% win for all panels opening:
https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&newProject=try&newRevision=0d223b985f81746880da0b1c6608fd0fa542297a&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&filter=.open&framework=1&selectedTimeRange=172800
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e2f8ba6e45c
Prevent updating toolbox react component until it is ready to be displayed. r=gregtatum
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•