Closed Bug 1399559 Opened 7 years ago Closed 7 years ago

AudioStream uses XRE_IsContentProcess without including nsXULAppAPI.h

Categories

(Core :: Audio/Video: Playback, defect, P3)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: philn, Assigned: cpearce)

References

Details

Attachments

(1 file)

Bug 1399559 - Include nsXULAppAPI.h in AudioStream.cpp.
(deleted), text/x-review-board-request
jwwang
: review+
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36 Steps to reproduce: AudioStream.cpp is calling XRE_IsContentProcess without including nsXULAppAPI.h, which results in a non-unified build failure.
Blocks: servo-media
Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core
Same issue in nsThreadManager.cpp BTW!
Comment on attachment 8907927 [details] Bug 1399559 - Include nsXULAppAPI.h in AudioStream.cpp. https://reviewboard.mozilla.org/r/179610/#review184800
Attachment #8907927 - Flags: review?(jwwang) → review+
Pushed by cpearce@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/37b749a726a9 Include nsXULAppAPI.h in AudioStream.cpp. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/37b749a726a9
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee: nobody → cpearce
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: