Closed
Bug 1399825
Opened 7 years ago
Closed 7 years ago
nsThreadManager uses XRE_IsContentProcess without including nsXULAppAPI.h
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: philn, Assigned: philn)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.78 Safari/537.36
Steps to reproduce:
nsThreadManager.cpp is calling XRE_IsContentProcess() without including nsXULAppAPI.h, which results in a non-unified build failure.
|
Assignee | |
Updated•7 years ago
|
Blocks: servo-media
|
|
Assignee | |
Comment 1•7 years ago
|
||
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8908074 [details] [diff] [review]
proposed.patch
I see no reason to ifdef this include; nothing in the file seems to be behind a windows check.
|
|
Assignee | |
Comment 3•7 years ago
|
||
Attachment #8908074 -
Attachment is obsolete: true
Attachment #8908105 -
Flags: review?(erahm)
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8908105 [details] [diff] [review]
proposed.patch
Review of attachment 8908105 [details] [diff] [review]:
-----------------------------------------------------------------
I claim my review powers cover this.
Attachment #8908105 -
Flags: review+
|
|
||
Updated•7 years ago
|
Assignee: nobody → philn
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38e7e0bba036
Include nsXULAppAPI.h in nsThreadManager.cpp. r=Ms2ger
Keywords: checkin-needed
|
||
Updated•7 years ago
|
Attachment #8908105 -
Flags: review?(erahm)
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•