Closed
Bug 1399917
Opened 7 years ago
Closed 7 years ago
Create --enable-address-sanitizer-reporter TC build
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla57
People
(Reporter: decoder, Assigned: decoder)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
For the ASan Nightly Project, we need a special ASan build that has --enable-address-sanitizer-reporter set to yes. For now I followed all the steps in bug 1359328 (when we added the --enable-fuzzing build) and created another job for this purpose.
For now, this job is without updates and signing, but after landing this, we will be working on both of these things in another bug.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8908195 [details]
Bug 1399917 - Create --enable-address-sanitizer-reporter TC build.
https://reviewboard.mozilla.org/r/179858/#review185980
Attachment #8908195 -
Flags: review?(aobreja) → review+
Comment 3•7 years ago
|
||
From my perspective the patch looks good even if some parts as those bellow are not very clear for me:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfe02dcfa163707c35493e240b26affbb861e055
taskcluster/ci/build/linux.yml
> PERFHERDER_EXTRA_OPTIONS: asan-reporter
> TOOLTOOL_MANIFEST: "browser/config/tooltool-manifests/linux64/releng.manifest"
> max-run-time: 36000
also I'm not sure why we don't use toolchains here:
> toolchains:
> - linux64-clang-4
> - linux64-gcc
> - linux64-sccache
Also the push to try went well:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfe02dcfa163707c35493e240b26affbb861e055&selectedJob=131728599
However I think I will also ask Mihai for a feedback since he has more experience with Taskcluster.
Flags: needinfo?(mtabara)
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8908195 [details]
Bug 1399917 - Create --enable-address-sanitizer-reporter TC build.
https://reviewboard.mozilla.org/r/179858/#review186532
Attachment #8908195 -
Flags: review+
Updated•7 years ago
|
Flags: needinfo?(mtabara)
Assignee | ||
Comment 5•7 years ago
|
||
I copied most of this from the other build configuration we have (for --enable-fuzzing). If anything is wrong with what we have there, then please let us know. Otherwise, I'll go ahead and land this now and see if the build works. Thanks!
Pushed by choller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5bce0c884d7a
Create --enable-address-sanitizer-reporter TC build. r=aobreja,mtabara
Comment 7•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•