Closed Bug 1399946 Opened 7 years ago Closed 7 years ago

eslint-plugin-mozilla: 0.4.3 documentation / possible bug issues.

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

3 Branch
defect
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: glind, Assigned: standard8)

References

Details

Attachments

(1 file)

Use case: linting jsm files for shield-study addons, outside main tree. 1. at https://www.npmjs.com/package/eslint-plugin-mozilla, the "link to gecko documentation" doesn't work. 2. I am getting ` 0:0 error Parsing error: Cannot read property 'ecmaFeatures' of undefined` errors when trying to use this .eslintrc.js extends: [ "eslint:recommended", //"plugin:mozilla/recommended", ], I would like docs on how to use the 'extends' and 'plugins' keys for the 0.4 series.
(In reply to Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat ) from comment #0) > Use case: linting jsm files for shield-study addons, outside main tree. > > 1. at https://www.npmjs.com/package/eslint-plugin-mozilla, the "link to > gecko documentation" doesn't work. That should be https://firefox-source-docs.mozilla.org/tools/lint/linters/eslint-plugin-mozilla.html - the in-tree README.md has been updated but we haven't published a new version since then... > 2. I am getting ` 0:0 error Parsing error: Cannot read property > 'ecmaFeatures' of undefined` errors when trying to use this .eslintrc.js > > extends: [ > "eslint:recommended", > //"plugin:mozilla/recommended", > ], > > I would like docs on how to use the 'extends' and 'plugins' keys for the 0.4 > series. You can use them in just the same ways as for other ESLint plugins, however you're hitting bug 1395879 - there should be an Espree release tomorrow, so hopefully on Monday I can get that resolved and will publish a new version. https://github.com/mozilla/followonsearch/ uses a slightly older version of the plugin, but how you include it etc should be able to remain the same.
Thank you for the update! Espree GRRRRRRR.
Since I spectacularly forgot to do version bumps in bug 1395879, then I'll do that here.
Assignee: nobody → standard8
Depends on: 1395879
Comment on attachment 8909217 [details] Bug 1399946 - Bump version number of eslint-plugin-mozilla for releasing the dependency fixes from bug 1395879. https://reviewboard.mozilla.org/r/180812/#review186040
Attachment #8909217 - Flags: review?(ahalberstadt) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/07684fbf1ab2 Bump version number of eslint-plugin-mozilla for releasing the dependency fixes from bug 1395879. r=ahal
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
I've now published 0.4.4, please let me know if you get any issues.
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: