Closed Bug 1399980 Opened 7 years ago Closed 7 years ago

Remove type-stylo special casing for Report Site Issue button

Categories

(Web Compatibility :: Tooling & Investigations, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: miketaylr, Assigned: miketaylr)

References

Details

(Whiteboard: [stylo:p3])

Attachments

(1 file)

This pref is shipping on in Nightly, so it's not super useful anymore.
While Stylo is enabled by default in Nightly 58 and Beta 57, we are still running an experiment that enables the old Gecko style system for 20% of Nightly users and 5% of Beta users. We want to make sure the old Gecko style system is still tested in case we need to disable Stylo at the last minute in Beta. We will probably shut off this experiment in Nightly 59 and Beta 58. Until then, this type-stylo label is still probably useful.
Whiteboard: [stylo]
Roger that, makes sense. Happy to hold off.
status-firefox57=wontfix unless someone thinks this bug should block 57
Assignee: nobody → miket
(patch for landing, whenever the experiment is done)
We will likely stop the Stylo enabled/disabled experiment (bug 1381147) in January.
Depends on: stylo-pref-study
Comment on attachment 8934303 [details]
Bug 1399980. Remove collection of stylo prefs in webcompat reports.

(this patch is bitrotted by the work in 1422985, but adding and removing prefs for reporting on will just be a one liner once that lands)
Attachment #8934303 - Attachment is obsolete: true
Mike, we stopped the Stylo experiments on 2018-01-09 (bug 1381147 comment 35) for all channels. All desktop users running Firefox 57+ should now be using Stylo, so you can remove the Stylo pref details from site issue reports whenever is convenient for you.
Flags: needinfo?(miket)
Whiteboard: [stylo] → [stylo:p3]
Cool, thanks Chris.
Flags: needinfo?(miket)
Comment on attachment 8934303 [details]
Bug 1399980. Remove collection of stylo prefs in webcompat reports.

https://reviewboard.mozilla.org/r/205210/#review223878
Attachment #8934303 - Flags: review?(florian) → review+
Thanks Florian. Not gonna put this on Try, it builds and works as expected locally.
Pushed by mitaylor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87c7321bb69d
Remove collection of stylo prefs in webcompat reports. r=florian
https://hg.mozilla.org/mozilla-central/rev/87c7321bb69d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: