Closed
Bug 1400096
Opened 7 years ago
Closed 7 years ago
Build mozmemory_wrap as C++
Categories
(Core :: Memory Allocator, enhancement)
Core
Memory Allocator
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(4 files)
No description provided.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8908458 [details]
Bug 1400096 - Remove mozmem_malloc_impl wrapping for operator methods exposed in mozmemory_wrap.c.
https://reviewboard.mozilla.org/r/180112/#review185272
Attachment #8908458 -
Flags: review?(n.nethercote) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8908459 [details]
Bug 1400096 - Annotate mozmemory_wrap.c windows functions as MOZ_MEMORY_API.
https://reviewboard.mozilla.org/r/180114/#review185274
Attachment #8908459 -
Flags: review?(n.nethercote) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8908460 [details]
Bug 1400096 - Build mozmemory_wrap as C++.
https://reviewboard.mozilla.org/r/180116/#review185276
::: commit-message-52c6c:3
(Diff revision 1)
> +Bug 1400096 - Build mozmemory_wrap as C++. r?njn
> +
> +And since the build system doesn't handle transitions to foo.c to
"from foo.c"
Attachment #8908460 -
Flags: review?(n.nethercote) → review+
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8908461 [details]
Bug 1400096 - Don't define the operator new/delete functions as mangled in mozmem_wrap.cpp.
https://reviewboard.mozilla.org/r/180118/#review185278
::: memory/build/mozmemory_wrap.cpp:56
(Diff revision 1)
> {
> return malloc_impl(size);
> }
> -/* operator delete(void*, std::nothrow_t const&) */
> -MOZ_MEMORY_API void
> -_ZdlPvRKSt9nothrow_t(void* ptr)
> +
> +MFBT_API void
> +operator delete(void* ptr, std::nothrow_t const&)
The nothrow_t argument disappears and just effectively becomes part of the function name? Interesting.
Attachment #8908461 -
Flags: review?(n.nethercote) → review+
|
Assignee | |
Comment 9•7 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #8)
> Comment on attachment 8908461 [details]
> Bug 1400096 - Don't define the operator new/delete functions as mangled in
> mozmem_wrap.cpp.
>
> https://reviewboard.mozilla.org/r/180118/#review185278
>
> ::: memory/build/mozmemory_wrap.cpp:56
> (Diff revision 1)
> > {
> > return malloc_impl(size);
> > }
> > -/* operator delete(void*, std::nothrow_t const&) */
> > -MOZ_MEMORY_API void
> > -_ZdlPvRKSt9nothrow_t(void* ptr)
> > +
> > +MFBT_API void
> > +operator delete(void* ptr, std::nothrow_t const&)
>
> The nothrow_t argument disappears and just effectively becomes part of the
> function name? Interesting.
Strictly speaking, it should have been there already, but it's not passed down, the C function signature doesn't change without it, and the file was a C source anyways, so it was not really possible to put it there.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 12•7 years ago
|
||
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/6cf651d919d1
Remove mozmem_malloc_impl wrapping for operator methods exposed in mozmemory_wrap.c. r=njn
https://hg.mozilla.org/integration/autoland/rev/092857175e36
Annotate mozmemory_wrap.c windows functions as MOZ_MEMORY_API. r=njn
https://hg.mozilla.org/integration/autoland/rev/09aa9fae6280
Build mozmemory_wrap as C++. r=njn
https://hg.mozilla.org/integration/autoland/rev/738de4c495b9
Don't define the operator new/delete functions as mangled in mozmem_wrap.cpp. r=njn
|
||
Comment 13•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6cf651d919d1
https://hg.mozilla.org/mozilla-central/rev/092857175e36
https://hg.mozilla.org/mozilla-central/rev/09aa9fae6280
https://hg.mozilla.org/mozilla-central/rev/738de4c495b9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•