Make window.content chrome-only
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox117 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: gregp)
References
(Blocks 1 open bug)
Details
(Keywords: site-compat)
Attachments
(1 file, 2 obsolete files)
(deleted),
text/x-phabricator-request
|
Details |
Updated•7 years ago
|
Updated•7 years ago
|
Reporter | ||
Comment 1•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Updated•7 years ago
|
Reporter | ||
Updated•7 years ago
|
Updated•6 years ago
|
Telemetry says currently only 0.08% of pages use this method: https://telemetry.mozilla.org/new-pipeline/dist.html#!measure=USE_COUNTER2_DEPRECATED_WindowContentUntrusted_PAGE&max_channel_version=beta%252F76 Since this has been disabled in Nightly for more than two years and there has been no relevant regression report so far, it's time to try disabling this on stable Firefox.
Updated•5 years ago
|
Comment 4•5 years ago
|
||
Ah, understood.
Then I'll modify the patch to only introduce the flag without actually disabling it, does this sound good?
Comment 7•5 years ago
|
||
It's probably also fine to disable it on Nightly. That way we catch potential fallout sooner.
It's probably also fine to disable it on Nightly.
It's already disabled in Nightly via preprecessor. IMO it's cleaner to disable it by a flag, though.
Comment 9•5 years ago
|
||
Comment on attachment 9142077 [details]
Bug 1400140 - Put window.content behind dom.window.content.enabled
Revision D71775 was moved to bug 1632116. Setting attachment 9142077 [details] to obsolete.
Comment 10•5 years ago
|
||
Here is Intent to unship: Visibility of window.content to untrusted code by bz 3 years ago
Comment 11•5 years ago
|
||
How about disabling it in the early beta channel as well if a new flag is introduced this time? @IS_EARLY_BETA_OR_EARLIER@
is often used.
That sounds good, as early beta users know breakages can happen.
Updated•4 years ago
|
Updated•2 years ago
|
Comment 13•1 years ago
|
||
dom.window.content.untrusted.enabled
= false since FF101 via Bug 1764339, maybe time to remove the pref/code?
Assignee | ||
Comment 14•1 year ago
|
||
Updated•1 year ago
|
Comment 15•1 year ago
|
||
Comment 16•1 year ago
|
||
bugherder |
Comment 17•1 year ago
|
||
Is this something we should call out in the Fx117 relnotes?
Assignee | ||
Comment 18•1 year ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #17)
Is this something we should call out in the Fx117 relnotes?
Probably not. For untrusted content, window.content is (was) an alias for window.top, it's also been unavailable to web content for about a year, so this change didn't really change the behavior much.
Comment 19•1 year ago
|
||
As this isn't needed to be called out in the release notes, I'm removing the dev-doc-needed keyword - feel free to re-apply if anyone thinks necessary
Description
•