Closed Bug 1400164 Opened 7 years ago Closed 7 years ago

(photon) New tabs open with the close button invisible, on tablets

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

57 Branch
ARM
Android
defect

Tracking

(fennec+, firefox57+ verified)

VERIFIED FIXED
Firefox 57
Tracking Status
fennec + ---
firefox57 + verified

People

(Reporter: ohorvath, Assigned: jwu)

References

Details

(Whiteboard: [FNC][SPT57.3][INT])

Attachments

(3 files)

Attached video rec1.mp4 (deleted) —
[Tracking Requested - why for this release]: Device: Asus ZenPad 8.0 Z380KL (Android 6.0.1) Lenovo Yoga Tablet 2 (Android 4.4.2) Build: Nightly 57.0a1 (2017-09-14); Steps to reproduce: 1. Tap the + button and add 2-3 new tabs. 2. Observe the x (close) button on the new empty tabs. Expected result: All tabs should have a visible close button. Actual result: The new empty tabs have an invisible close button. The button will sometimes appear back if you tap the tab, but not always (see the last tab tapped in the recording attached). Note: Not reproducing with themes added. Not reproducing by opening links in new tabs.
I am not reproducing this with : - Pixel C (Android 7.1.1) - Galaxy Not Pro (Android 5.0.2)
Jingwei, I don't think it's blocking the entering of beta, but would you help check this with the devices you have in hand? Thanks!
Flags: needinfo?(topwu.tw)
No problem, I would file a patch for reviewing ASAP.
Assignee: nobody → topwu.tw
Flags: needinfo?(topwu.tw)
Comment on attachment 8909179 [details] Bug 1400164 - Part 1: Provide a getter method for tint colors of themed widgets. https://reviewboard.mozilla.org/r/180756/#review185876
Attachment #8909179 - Flags: review?(cnevinchen) → review+
Comment on attachment 8909180 [details] Bug 1400164 - Part 2: Tint close button manually when checked status is changed. https://reviewboard.mozilla.org/r/180758/#review185878
Attachment #8909180 - Flags: review?(cnevinchen) → review+
Pushed by topwu.tw@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ff594f5d6356 Part 1: Provide a getter method for tint colors of themed widgets. r=nechen https://hg.mozilla.org/integration/autoland/rev/e015f756f2fc Part 2: Tint close button manually when checked status is changed. r=nechen
Whiteboard: [FNC][SPT57.3][INT]
tracking-fennec: ? → +
Priority: -- → P1
Verified as fixed in Nightly 57 (2017-09-21). Devices: Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: