Closed
Bug 14003
Opened 25 years ago
Closed 24 years ago
finish -version in xpfe/bootstrap/nsAppRunner.cpp
Categories
(Core Graveyard :: Cmd-line Features, defect, P4)
Core Graveyard
Cmd-line Features
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: sspitzer, Assigned: mcafee)
Details
(Keywords: helpwanted, Whiteboard: [FEATURE][PDTP4][nsbeta3-] relnote-user)
Attachments
(2 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
in mozilla/xpfe/bootstrap/nsAppRunner.cpp I started the work for
-h,--help,-help,-v,-version,--version support.
mcafee, can you finish that work?
all that's left is dumping out the right text.
see DumpHelp() and DumpVersion() in nsAppRunner.cpp
I put the code to do that right after main() gets called, so -v and -h return
quickly, without doing a bunch of COM crap.
if we want to make the -v and -h output localizable (tao?), we should use a
string bundle, and that may means we have to move the -v / -h to after some COM
stuff gets initialized.
Assignee | ||
Updated•25 years ago
|
Target Milestone: M12
Reporter | ||
Comment 2•25 years ago
|
||
we have this bug because -v and -h don't work yet.
it's a place holder bug.
it's really low priority.
Assignee | ||
Updated•25 years ago
|
Assignee: mcafee → cyeh
Summary: finish -version and -help in nsAppRunner.cpp → finish -version in xpfe/bootstrap/nsAppRunner.cpp
Assignee | ||
Comment 5•25 years ago
|
||
I've fixed the -help part of this,
now we need a way to find the version from C++,
over to cyeh, the version czar.
Reporter | ||
Comment 6•25 years ago
|
||
I just noticed that mozilla calls run-mozilla.sh which will eat the -h flag,
instead of passing it through to mozilla-bin, which is one that will spit out
the help when you pass it -h.
perhaps we should tweak run-mozilla.sh so that it dumps usage when it gets -h,
and then passes -h to mozilla-bin, instead of just dumping usage and then
exiting?
Assignee | ||
Comment 7•25 years ago
|
||
or, just let mozilla-bin handle -h.
either way, scripts should pass unhandled flags on to
the mozilla binary, we'll need this for gtk/X11 flags
like --sync.
Reporter | ||
Comment 8•25 years ago
|
||
I agree, let mozilla-bin handle -h
but the problem is if you run the app by doing mozilla, this calls
run-mozilla.sh, which will eat the -h and exit, before we even get to
mozilla-bin
Assignee | ||
Comment 9•25 years ago
|
||
Version problem still exists.
Moving argument handling discussion to bug 23084.
Comment 10•25 years ago
|
||
looks like mcafee should own this, not me
Updated•24 years ago
|
Comment 12•24 years ago
|
||
Putting on [nsbeta2-] radar. If someone can help to get this done. Let us know.
Whiteboard: [FEATURE] → [nsbeta2-][FEATURE]
Assignee | ||
Comment 14•24 years ago
|
||
Assignee | ||
Comment 15•24 years ago
|
||
posted patch that implements -version, I get an assert
in nsServiceManager, but ? we exit right after that
so maybe this is Ok.
Status: NEW → ASSIGNED
Keywords: patch
Updated•24 years ago
|
Component: Browser-General → XP Apps: Cmd-line Features
QA Contact: mcafee → sairuh
Comment 16•24 years ago
|
||
Nav triage team: [nsbeta3+]
Whiteboard: [nsbeta2-][FEATURE] → [nsbeta2-][FEATURE][nsbeta3+]
Comment 17•24 years ago
|
||
Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so
the queries don't get all screwed up.
Keywords: nsbeta3
Assignee | ||
Updated•24 years ago
|
Priority: P3 → P1
Comment 18•24 years ago
|
||
PDT marking P4 and putting [PDTP4] in status whiteboard
Priority: P1 → P4
Whiteboard: [nsbeta2-][FEATURE][nsbeta3+] → [nsbeta2-][FEATURE][nsbeta3+][PDTP4]
Comment 19•24 years ago
|
||
mcafee, have you had a chance to get the patch reviewed for checkin? thx!
Comment 20•24 years ago
|
||
Marking "nsbeta3-".
Whiteboard: [nsbeta2-][FEATURE][nsbeta3+][PDTP4] → [nsbeta2-][FEATURE][nsbeta3-][PDTP4][cut 0919]
Comment 21•24 years ago
|
||
why was this minused? there's a patch attached waiting for review... (sorry
about my previous comment, forgot mcafee submitted the patch himself.) clearing
status for pdt to reconsider.
Whiteboard: [nsbeta2-][FEATURE][nsbeta3-][PDTP4][cut 0919] → [FEATURE][PDTP4]
Comment 22•24 years ago
|
||
This is nsbeta3- because it's just not a serious problem that we need to fix for
b3 or rtm.
Whiteboard: [FEATURE][PDTP4] → [FEATURE][PDTP4][nsbeta3-]
Updated•24 years ago
|
Keywords: relnoteRTM
Comment 23•24 years ago
|
||
It seems unclear to me whether this bug requires either of a "developer" or
"user" release note. If anyone feels it does, can they please draft one and then
nominate with the relnote-user or relnote-rtm strings in the Status Whiteboard.
Thanks :-)
Gerv
Comment 24•24 years ago
|
||
to get the browser version, please run [...] -version instead of [...]
-version. Or just run the app and go to help about.
[...] because i don't know which the things are :-(
Whiteboard: [FEATURE][PDTP4][nsbeta3-] → [FEATURE][PDTP4][nsbeta3-] relnote-user
Comment 25•24 years ago
|
||
Netscape Nav triage team: this is not a Netscape beta stopper.
Keywords: helpwanted,
nsbeta1-
Reporter | ||
Comment 26•24 years ago
|
||
I've revised mcafee's patch. I'll attach it.
mcafee / alecf, can you review?
I'm not getting the assertion that mcafee reported.
Reporter | ||
Comment 27•24 years ago
|
||
Reporter | ||
Comment 28•24 years ago
|
||
on linux, here is what my debug build spits out:
Mozilla/5.0 (X11; N; Linux 2.2.12-20 i686) <developer build>
that is preceeded by some other debugging printfs. the total output from my
debug linux build is:
> ./mozilla -version
./run-mozilla.sh ./mozilla-bin -version
MOZILLA_FIVE_HOME=/builds/seth/seamonkey/mozilla/dist/bin
LD_LIBRARY_PATH=/builds/seth/seamonkey/mozilla/dist/bin
LIBRARY_PATH=/builds/seth/seamonkey/mozilla/dist/bin:/builds/seth/seamonkey
/mozilla/dist/bin/components
SHLIB_PATH=/builds/seth/seamonkey/mozilla/dist/bin
LIBPATH=/builds/seth/seamonkey/mozilla/dist/bin
ADDON_PATH=/builds/seth/seamonkey/mozilla/dist/bin
MOZ_PROGRAM=./mozilla-bin
MOZ_TOOLKIT=
moz_debug=0
moz_debugger=
Type Manifest File: /builds/seth/seamonkey/mozilla/dist/bin/components/xpti.dat
HTTP Handler: Instantiating contractid @mozilla.org/cookie-notifier;1
in http startup category.
Mozilla/5.0 (X11; N; Linux 2.2.12-20 i686) <developer build>
Comment 29•24 years ago
|
||
why did you remove the "static" aspect of this function?
sr=alecf with "static" returned
Reporter | ||
Comment 30•24 years ago
|
||
removing static was not intentional.
I've added it back and I've checked it in.
thanks for the review.
thanks to mcafee for the original patch.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 31•24 years ago
|
||
thanks for chasing this down, seth.
Comment 32•24 years ago
|
||
works just spiffily on linux [comm verif 2000.12.21.08 bits], but not on win32
verification bits. am gonna verify this anyhow, since it works on win32 debug.
will add a note to bug 26761 on that...
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•