Once nsIAtom is devirtualized (bug 1400459) it should be renamed as nsAtom. This will be a large but mechanical change.

This is awesome, fwiw. Curious question, why nsAtom and not mozilla::Atom or something like that?

> Curious question, why nsAtom and not mozilla::Atom or something like that? There are 16,000+ occurrences of "nsIAtom" in the code. Changing it to nsAtom can be done with global search-and-replace. Changing it to mozilla::Atom is harder because you sometimes need "mozilla::Atom" and sometimes need "Atom". Also, "mozilla::Atom" is longer and can mess up formatting by creating overly long lines. If someone wants to volunteer to convert it to mozilla::Atom in a way that keeps formatting nice, it's fine by me :) Otherwise, I will take the easy route and just make it nsAtom.

I will fold all the patches together before landing, but they're separate for now to ease reviewing. The ones for .cpp, .h, .mm, and .rs files were done with automated search-and-replace.

Comment on attachment 8914220 [details] [diff] [review] Rename nsIAtom as nsAtom Review of attachment 8914220 [details] [diff] [review]: ----------------------------------------------------------------- Yay!

Comment on attachment 8914221 [details] [diff] [review] *.js, *.py, *.toml, *dbinit Review of attachment 8914221 [details] [diff] [review]: ----------------------------------------------------------------- ::: .gdbinit @@ +85,5 @@ > pu $str.mData $str.mLength > end > end > > +# Define a "pa" command to display the string value for an nsAtom I commend your thoroughness.

> I commend your thoroughness. Thank you. I harnessed the power of rgrep! There is a single nsIAtom reference left in the tree: http://searchfox.org/mozilla-central/rev/298033405057ca7aa5099153797467eceeaa08b5/third_party/python/lldbutils/README.txt#163 Because it's in third_party/ I'm not sure how to update it, but it's just a comment so I haven't bothered investigating further.

Comment on attachment 8916454 [details] Bug 1400460 - Rename nsIAtom as nsAtom. . https://reviewboard.mozilla.org/r/187568/#review192566

Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/67a8e1232456 Rename nsIAtom as nsAtom. r=hiro.

Comment on attachment 8916454 [details] Bug 1400460 - Rename nsIAtom as nsAtom. . https://reviewboard.mozilla.org/r/187568/#review192776 I guess I should r+ this even though it's already landed?

> I guess I should r+ this even though it's already landed? Sorry, autoland isn't very flexible :/

So the patches modified autogenerated files, like nsHtml5Tokenizer.cpp without fixing the code which autogenerates the code. https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/parser/html/nsHtml5Tokenizer.cpp#27,33 https://hg.mozilla.org/mozilla-central/diff/67a8e1232456/parser/html/nsHtml5Tokenizer.cpp

> So the patches modified autogenerated files, like nsHtml5Tokenizer.cpp > without fixing the code which autogenerates the code. Is that code in a different repository?

hsivonen would know the setup the best, but yes https://hg.mozilla.org/projects/htmlparser You may want to read also https://searchfox.org/mozilla-central/source/parser/html/java/README.txt

Bug 1400460 renamed nsIAtom to nsAtom in the generated parser code (and reformatted it) without updating the Java translator. I updated the Java translator in bug 1424548.

Thank you, cpeterson!