Closed Bug 1400504 Opened 7 years ago Closed 6 years ago

No obvious way to tell what a mach try preset really maps to

Categories

(Developer Infrastructure :: Try, enhancement)

Product:
Developer Infrastructure
Component:
Try
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: bzbarsky, Unassigned)

References

Details

"mach try --list-presets" gives me output like: linux64-tests: test-linux64 "linux64-tests" is the stirng I passed to --save. I have no idea what "test-linux64" came from or what it actually means. I just tried to create a preset that does a Linux32 debug build and then runs only part of an opt linux32 xpcshell test. That preset says, in --list-presets: test-preset: test-linux whatever that means...
Summary: No obvious way to tell what a preset really maps to → No obvious way to tell what a mach try preset really maps to
Oh, I created that preset with "mach try fuzzy". Presets I create with "mach try syntax" do show the try syntax involved. Interestingly, "mach try --list-presets" lists both fuzzy and syntax presets, which can have overlapping names...
Product: TaskCluster → Firefox Build System
Component: Task Configuration → Try
Depends on: 1518572

With the landing of bug 1518572, I think this bug can be closed. Presets are now more structured and look like this:

<name>:
    selector: <selector>
    <args>

So for example, saving a preset like this:

$ ./mach try fuzzy --save foo --query "linux64 debug mochitest"

Will result in a preset like this:

foo:
    selector: fuzzy
    query:
        - "linux64 debug mochitest"

The <args> portion of a preset directly corresponds to the parameters each selector's run function takes. In fuzzy's case, that is this function:
https://searchfox.org/mozilla-central/source/tools/tryselect/selectors/fuzzy.py#207

Also preset names from different selectors can no longer collide.

Boris, please feel free to re-open if you think there are still things to fix here.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX

No, I think this does what I wanted, in terms of being able to figure out what a preset does. The syntax ones are listed in a kinda annoying way that makes it hard to edit them to create a new one, but I can manage. ;)

Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.