mdew Reporter
	Description • 7 years ago

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170915192121

Steps to reproduce:

Not sure if its been requested previosly, but the option of having another Row would be nice (since we can't modify the column/row options anymore)


Actual results:

Able to select between 2 or 3 rows as an option if the user wishes


Expected results:

Attached is a sample of how the design would be

	Ben Kelly [:bkelly, not reviewing]
	Comment 2 • 7 years ago

FWIW I'm seeing this feature requested frequently on twitter since firefox quantum released.

	Ben Kelly [:bkelly, not reviewing]
	Comment 3 • 7 years ago

Also, as some personal feedback, I found the "edit" feature a bit hard to discover.  For some reason I expected this to either be in the side panel with other settings or at the bottom left of the widget.  I didn't initially look for this kind of feature near the "?" help icon in the upper right of the widget.

	Ed Lee :Mardak
	Comment 4 • 7 years ago

uiwanted: This was left off in providing more details for `two "more rows" "fewer rows" options`

	Ed Lee :Mardak
	Comment 5 • 7 years ago

The design will be via about:preferences perhaps with a dropdown.

Each section (highlights) needs to have a pref to control rows. Top sites might need to convert to rows instead of count.

	Ed Lee :Mardak
	Comment 6 • 7 years ago

uifeedback: https://mozilla.invisionapp.com/share/EGFI16P8Y36#/screens/276669529_Preferences_-_Home_Selected

row drop down are to the right of the section description text

	Ed Lee :Mardak
	Comment 7 • 6 years ago

Bug 1404890 will land the strings for this bug: {num} row;{num} rows

	Ed Lee :Mardak
	Comment 8 • 6 years ago

Bug 1404890 is adding the 1 row/2 rows drop down for top sites, which already has a pref for rows. This bug will need to figure out how to save the user selected rows value for other sections. And also have top sites handle up to 4 rows.

	Ricky Rosario [:rrosario, :r1cky] Assignee
	Comment 10 • 6 years ago

I filed a followup to deal with Top Sites - Bug 1465398

	[github robot]
	Comment 11 • 6 years ago

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/49e8a52753049b7565c2cce4da8a6781d1010b79
feat(preferences): Allow user set rows for sections (#4179)

Fix Bug 1400536 - Add an option for showing more / fewer rows in New Tab sections

	Ed Lee :Mardak
	Comment 12 • 6 years ago

https://hg.mozilla.org/mozilla-central/rev/609a288fe314

	Ciprian Muresan [:cmuresan], Ecosystem QA
	Comment 13 • 6 years ago

The issue is no longer reproducible on the latest Nightly 62.0a1 (Build ID 20180604100129) on Windows 10 x64, Mac 10.13.4 and Ubuntu 16.04 x32. The "Recommended by Pocket" and "Highlights" sections can now be customized to show up to 4 rows.

	Sylvestre Ledru [:Sylvestre]
	Comment 14 • 6 years ago

Is that something we want to add to the release notes?

	Ed Lee :Mardak
	Comment 15 • 6 years ago

Maria, comment 14 for 62, should there be release notes relating to these customization changes? If so, probably could be mentioned with bug 1465398 so all sections (top sites, pocket, highlights) can be configured 1 to 4 rows now.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 16 • 6 years ago

Adding to the beta 62 release notes as:

New tab page sections such as top sites, highlights, and Pocket can be adjusted to include 1 to 4 rows in the Preferences

If you'd like to change that wording, please let me know.