Closed Bug 1400804 Opened 7 years ago Closed 7 years ago

(photon) First run tour - the Sync button is not visible, or squished, in landscape

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

57 Branch
ARM
Android
defect

Tracking

(fennec+, firefox57+ verified)

VERIFIED FIXED
Firefox 57
Tracking Status
fennec + ---
firefox57 + verified

People

(Reporter: ohorvath, Assigned: cnevinchen, NeedInfo)

References

Details

(Whiteboard: [FNC][SPT58.1][INT])

Attachments

(2 files)

Attached image LG G4 (Android 6.0).png (deleted) —
[Tracking Requested - why for this release]: Devices: Huawei MediaPad M2 (Android 5.1.1) Asus ZenPad 8.0 Z380KL (Android 6.0.1) Prestigio Grace X5 (Android 4.4.2) LG G4 (Android 6.0) Build: Nightly 57.0a1 (2017-09-17); Steps to reproduce: 1. With a clean profile, open Nightly. 2. Go to the Sync tab and turn the device in landscape mode. 3. Scroll down to see the sync button. Expected result: The buttons should be visible and should keep the same layout as in portrait. Actual result: On some devices, the button is not visible at all, cannot scroll lower than the "Start browsing" button. On others, the button is visible, but the text & buttons are squished together. See screenshots attached.
Flags: needinfo?(cnevinchen)
Nevin, would you help check it now since we are about to merge today.
Comment on attachment 8909247 [details] Bug 1400804 - First run tour - the Sync button is not visible. https://reviewboard.mozilla.org/r/180840/#review185938
Attachment #8909247 - Flags: review?(topwu.tw) → review+
Assignee: nobody → cnevinchen
Flags: needinfo?(cnevinchen)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 998c99d4c268 -d 8f132dd91e9c: rebasing 421210:998c99d4c268 "Bug 1400804 - First run tour - the Sync button is not visible. r=jwu" (tip) merging mobile/android/app/src/main/res/layout/firstrun_sync_fragment.xml warning: conflicts while merging mobile/android/app/src/main/res/layout/firstrun_sync_fragment.xml! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Hi Peko, please take a look at this onboarding layout.
Flags: needinfo?(pchen)
APK here https://drive.google.com/file/d/0Bw-r8iYPh2ZDeW1LX0VxaFh0Qmc/view?usp=sharing This needs to be landed before end of Sep 20
The apk looks good on my devices: Asus ZenPad 8.0 Z380KL (Android 6.0.1) Huawei MediaPad M2 (Android 5.1.1) Motorola Nexus 6 (Android 7.0) HTC 10 (Android 7.0.1)
Pushed by nechen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/865bfef2c528 First run tour - the Sync button is not visible. r=jwu
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Verified as fixed in Nightly 57 (2017-09-21). Devices: Asus ZenPad 8.0 Z380KL (Android 6.0.1) Motorola Nexus 6 (Android 7.0) Samsung Galaxy Note 4 (Android 5.0.1) Lenovo Yoga Tablet 2 (Android 4.4.2) Prestigio Grace X5 (Android 4.4.2)
Status: RESOLVED → VERIFIED
Whiteboard: [FNC][SPT58.1][INT]
tracking-fennec: ? → +
Priority: -- → P1
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: