Closed
Bug 1401071
Opened 7 years ago
Closed 7 years ago
Fix nits for mp4parse_fallible
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: ayang, Assigned: ayang)
References
Details
Attachments
(1 file)
There are several nits need to be fixed in orevisou PRs including:
. move mp4parse_fallible out of mp4parser
. use 'feature' to control fallible memory allocation
. remove redundant error code TableTooLarge
. rename reserve_read_buf to allocate_read_buf
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → ayang
|
|
Assignee | |
Comment 2•7 years ago
|
||
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8911634 [details]
Bug 1401071 - move fallible memory allocation github instead of including source and other nits.
https://reviewboard.mozilla.org/r/183034/#review188196
Attachment #8911634 -
Flags: review?(kinetik) → review+
|
||
Updated•7 years ago
|
Priority: -- → P3
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•7 years ago
|
||
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edae6c684c0e
move fallible memory allocation github instead of including source and other nits. r=kinetik
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Comment 9•7 years ago
|
||
Did you want to request Beta approval on this to fix bug 1389527?
|
|
Assignee | |
Comment 10•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #9)
> Did you want to request Beta approval on this to fix bug 1389527?
No, it is an invalid mp4 stream, current train is good enough.
Flags: needinfo?(ayang)
|
||
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•