Closed
Bug 1401399
Opened 7 years ago
Closed 7 years ago
The URL field in the Activity Streams edit UI needs to be LTR always
Categories
(Firefox :: New Tab Page, enhancement)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 57
People
(Reporter: ehsan.akhgari, Assigned: Mardak)
References
Details
(Keywords: rtl)
Attachments
(2 files)
[Tracking Requested - why for this release]: RTL issue affecting the first release shipping activity streams.
See the screenshot from an RTL build showing the edit UI for the new tab page. The URL field shows the slash at the end of the URL at the left hand of the URL, because the text box is inheriting the direction of the page (LTR). The text box's direction needs to be set to ltr explicitly to avoid this. We do this everywhere in our UI where we display URLs.
Assignee | ||
Comment 1•7 years ago
|
||
So, I guess we need to keep it rtl while it's showing the placeholder text but switch to ltr when there's a value?
Blocks: 1394533
Assignee | ||
Comment 2•7 years ago
|
||
Oh. I see the location bar keeps the text right aligned but is ltr.
Assignee | ||
Comment 3•7 years ago
|
||
Assignee: nobody → edilee
Assignee | ||
Updated•7 years ago
|
Attachment #8910047 -
Attachment description: fixed → before top, after bottom
Reporter | ||
Comment 4•7 years ago
|
||
The alignment should be right-aligned. As far as the directionality goes, the placeholder text may be localized, so that should be RTL in RTL builds, but URLs are always left to right, so they should be LTR.
Reporter | ||
Comment 5•7 years ago
|
||
Beware that without a period or slash or something like that at the end of the placeholder text, you can't tell if the direction of the placeholder text is wrong. So for example, the screenshot you just posted is inconclusive about that. :-)
Assignee | ||
Comment 6•7 years ago
|
||
Assignee | ||
Comment 7•7 years ago
|
||
Fixed by https://github.com/mozilla/activity-stream/pull/3550 to be uplifted via bug 1401418.
Updated•7 years ago
|
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•