Closed
Bug 1401527
Opened 7 years ago
Closed 7 years ago
Remove strings for recent bookmarks and/or pocket items in bookmarks menu(s)
Categories
(Firefox :: Bookmarks & History, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 60
People
(Reporter: Gijs, Assigned: standard8)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
bug 1401238 removed the recent bookmarks and 'view pocket list' items, but left the strings in case we change our mind. If we don't, we should remove the strings at the end of the 58 cycle / beginning of the 59 cycle.
|
Assignee | |
Comment 1•7 years ago
|
||
Gijs, is it safe to do this now, or is there someone we should check in with?
Component: General → Bookmarks & History
Whiteboard: [fxsearch]
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
|
Reporter | |
Comment 2•7 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #1)
> Gijs, is it safe to do this now, or is there someone we should check in with?
No, this is safe. Both strings may be used elsewhere now, would be good to doublecheck, of course.
Flags: needinfo?(gijskruitbosch+bugs)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → standard8
|
|
Assignee | |
Comment 3•7 years ago
|
||
Of the strings that I can find in code removals in bug 1401238, still used:
- recentBookmarks.label (https://searchfox.org/mozilla-central/search?q=recentBookmarks.label&case=false®exp=false&path=)
- pocketMenuitem.label (https://searchfox.org/mozilla-central/search?q=pocketMenuitem.label&case=false®exp=false&path=)
now unused:
- hideRecentlyBookmarked.label/accesskey (https://searchfox.org/mozilla-central/search?q=hideRecentlyBookmarked.&case=false®exp=false&path=)
- showRecentlyBookmarked.label/accesskey (https://searchfox.org/mozilla-central/search?q=showRecentlyBookmarked.&case=false®exp=false&path=)
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8950882 [details]
Bug 1401527 - Remove unused 'Recently Bookmarked' strings.
https://reviewboard.mozilla.org/r/220136/#review226010
Attachment #8950882 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00bb6658c45a
Remove unused 'Recently Bookmarked' strings. r=Gijs
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•