Closed Bug 1401594 Opened 7 years ago Closed 7 years ago

Upgrade Firefox 58 to use NSS 3.34

Categories

(Core :: Security: PSM, enhancement, P1)

Product:
Core
Component:
Security: PSM
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: KaiE, Assigned: franziskus)

Details

(Whiteboard: [psm-assigned])

Attachments

(3 files)

1401594-optionget.patch
(deleted), patch
franziskus
: review+
Details | Diff | Splinter Review
1401594-abi-part2.patch
(deleted), patch
franziskus
: review+
Details | Diff | Splinter Review
update nss 3.34 RTM
(deleted), text/plain
gchang
: approval-mozilla-beta+
Details
Tracking NSS 3.34 for Firefox 58.
Attached patch 1401594-optionget.patch (deleted) — — Splinter Review
The changes from bug 1399867 caused Firefox to depend on NSS_OptionGet (discovered in a try build).
Attachment #8910323 - Flags: review?(franziskuskiefer)
Attachment #8910323 - Flags: review?(franziskuskiefer) → review+
Assignee: nobody → franziskuskiefer
status-firefox57: affected → ---
Keywords: leave-open
Priority: -- → P1
Whiteboard: [psm-assigned]
status-firefox57: --- → wontfix
Target Milestone: --- → mozilla58
Pushed by ttaubert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ce1462f8f6cd land NSS 4bf658832d89 UPGRADE_NSS_RELEASE, r=me
Attached patch 1401594-abi-part2.patch (deleted) — — Splinter Review
silence ABI warning for new functions
Attachment #8921756 - Flags: review?(franziskuskiefer)
Comment on attachment 8921756 [details] [diff] [review] 1401594-abi-part2.patch Review of attachment 8921756 [details] [diff] [review]: ----------------------------------------------------------------- Not sure if this is the best bug to put this in. But the patch looks good to me.
Attachment #8921756 - Flags: review?(franziskuskiefer) → review+
I agree, in the future, with working ABI-checks, it will be easier to match these changes to the most recent NSS commits that made them necessary. https://hg.mozilla.org/projects/nss/rev/e1214758f30b
Pushed by franziskuskiefer@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/100e006a2730 land NSS NSS_3_34_BETA1 UPGRADE_NSS_RELEASE, r=me
Pushed by franziskuskiefer@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4230f196a3a1 land NSS NSS_3_34_BETA2 UPGRADE_NSS_RELEASE, r=me
Pushed by franziskuskiefer@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/34e1dd628fb3 land NSS NSS_3_34_BETA3 UPGRADE_NSS_RELEASE CLOSED TREE, r=me
Pushed by franziskuskiefer@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/40444386933a land NSS NSS_3_34_BETA5 UPGRADE_NSS_RELEASE, r=ttaubert
Attached file update nss 3.34 RTM (deleted) —
This only removes the beta tag. No code changes.
Attachment #8928116 - Flags: approval-mozilla-beta?
Flags: needinfo?(gchang)
Comment on attachment 8928116 [details] update nss 3.34 RTM Upgrade Firefox 58 to use NSS 3.34. Beta58+.
Flags: needinfo?(gchang)
Attachment #8928116 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Keywords: leave-open
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: