Closed
Bug 1401691
Opened 7 years ago
Closed 7 years ago
Consider allowing windowId for browser.theme.reset
Categories
(WebExtensions :: General, defect, P5)
Tracking
(firefox57 fixed, firefox58 fixed)
VERIFIED
FIXED
mozilla58
People
(Reporter: jkt, Assigned: ntim)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
jaws
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details |
Reset clears my styles to native which is super useful, however I then have to calculate all the visible windows again.
If I could pass a windowId to browser.theme.reset() this would be simpler and less janky.
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Blocks: themingapi
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ntim.bugs
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jkt)
Reporter | ||
Comment 1•7 years ago
|
||
As mentioned on irc the current code doesn't work with reset.
I created a branch here: https://github.com/jonathanKingston/containers-theme/tree/reset-theme
This currently works across containers, however when you change to a default tab it will retain the containers theme.
:ntim I can double check the code works when you have a patch (which it sounds like you have).
Flags: needinfo?(jkt) → needinfo?(ntim.bugs)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
I think this can be considered for 57, as the patch is pretty straightforward and low-risk.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8913738 [details]
Bug 1401691 - Accept windowId parameter for browser.theme.reset().
https://reviewboard.mozilla.org/r/185126/#review190294
Attachment #8913738 -
Flags: review?(jaws) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/55e00fb0f00b
Accept windowId parameter for browser.theme.reset(). r=jaws
Comment 7•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8913738 [details]
Bug 1401691 - Accept windowId parameter for browser.theme.reset().
Approval Request Comment
[Feature/Bug causing the regression]: bug 1342712
[User impact if declined]: None for users, but the API introduced in bug 1342712 will be incomplete, as its equivalent for reset() won't be supported
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: Straightforward JS changes, that have the same logic as bug 1342712, which has been well tested.
[String changes made/needed]: none
Attachment #8913738 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 9•7 years ago
|
||
:jkt, can you please verify that this works for your add-on in Nightly ? Thanks!
Flags: needinfo?(jkt)
Reporter | ||
Comment 10•7 years ago
|
||
I can confirm that the patch in Nightly now works with the branch that I made, thank you!
Flags: needinfo?(jkt)
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Comment 11•7 years ago
|
||
What kind of extension would use this?
By the way, there is no test?
Flags: needinfo?(ntim.bugs)
Assignee | ||
Comment 12•7 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #11)
> What kind of extension would use this?
Theme related extensions: VivaldiFox (I'm working on a port for 57 atm), Containers theme.
> By the way, there is no test?
Both bug 1342712 and this bug don't have testing coverage, since I landed those in a rush to be able to port my own extensions in time for 57.
I do plan to add tests later separately though.
Flags: needinfo?(ntim.bugs)
Comment 13•7 years ago
|
||
Comment on attachment 8913738 [details]
Bug 1401691 - Accept windowId parameter for browser.theme.reset().
OK, taking it to help theme support.
Tim, please report a new bug to make sure we don't forget about adding tests.
Thanks
Attachment #8913738 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 14•7 years ago
|
||
Thanks! Filed bug 1404855 for tests
Assignee | ||
Comment 15•7 years ago
|
||
uplift |
Assignee | ||
Updated•7 years ago
|
Keywords: dev-doc-needed
Comment 16•7 years ago
|
||
Updated doc (thanks ntim):
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/theme/reset
Keywords: dev-doc-needed → dev-doc-complete
Assignee | ||
Updated•7 years ago
|
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•