Closed
Bug 1401772
Opened 7 years ago
Closed 4 years ago
Use switches instead of checkboxes in Sync Preferences
Categories
(Firefox for Android Graveyard :: Firefox Accounts, enhancement, P5)
Firefox for Android Graveyard
Firefox Accounts
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: Grisha, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Grisha
:
review-
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•7 years ago
|
Updated•7 years ago
|
Whiteboard: [FxA]
Comment 1•7 years ago
|
||
Couldn't get MozReview setup correctly, in the meantime this was a patch I used to get toggle switches in android. r?
Attachment #8921715 -
Flags: review?(gkruglov)
Updated•7 years ago
|
Assignee: nobody → vbudhram
Reporter | ||
Comment 2•7 years ago
|
||
Comment on attachment 8921715 [details] [diff] [review]
Patch to use toggle switches instead of checkboxes
Review of attachment 8921715 [details] [diff] [review]:
-----------------------------------------------------------------
This was also my first attempt at this, which I backed out because it didn't behave correctly on older API levels (around API16, IIRC?).
Check out Bug 1401773. You'll definitely want to investigate this - ensure that you can toggle these on/off, sync, have them persist, etc., all on newer and older APIs.
Also, we probably do want to keep the "sync only over wifi" separate from the list of engines, since they're quite different things. Any reason you moved it?
Attachment #8921715 -
Flags: review?(gkruglov) → review-
Reporter | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Comment 3•7 years ago
|
||
Sorry for late response. Didn't know you pushed a similar PR. I will investigate the API16 issues and see if I can get a better solution.
> Any reason you moved it?
Heh nope, I'll revert.
Updated•7 years ago
|
Assignee: vbudhram → nobody
Status: ASSIGNED → NEW
Whiteboard: [FxA]
Comment 4•6 years ago
|
||
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195
Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5
Comment 5•4 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•