Closed
Bug 1401845
Opened 7 years ago
Closed 7 years ago
Add common android config to ServoBindings.toml
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
Since Android build uses cross compiler toolchain, we need a lot of options for bindgen and clang. But some options such as --target is common rule, so we should define it in ServoBindings.toml
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8910688 [details] Bug 1401845 - Add common android config to ServoBindings.toml. https://reviewboard.mozilla.org/r/182118/#review187744 Looks fine, thanks!
Attachment #8910688 -
Flags: review?(emilio) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/e8d759e20037 Add common android config to ServoBindings.toml. r=emilio
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e8d759e20037
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
status-firefox57:
affected → ---
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•