Closed
Bug 1401917
Opened 7 years ago
Closed 7 years ago
Tab strip scroll button fill-opacity is off
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 58
People
(Reporter: dao, Assigned: dao)
References
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
nhnt11
:
review+
Sylvestre
:
approval-mozilla-beta+
|
Details |
In bug 1384686 I introduced --toolbarbutton-icon-fill-opacity but accidentally didn't use it for the scroll buttons.
Assignee | ||
Updated•7 years ago
|
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [reserve-photon-visual]
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8910685 [details]
Bug 1401917 - Let tab strip scroll buttons use --toolbarbutton-icon-fill-opacity.
https://reviewboard.mozilla.org/r/182142/#review187512
Attachment #8910685 -
Flags: review?(nhnt11) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32d758581c46
Let tab strip scroll buttons use --toolbarbutton-icon-fill-opacity. r=nhnt11
Comment 4•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Assignee | ||
Comment 5•7 years ago
|
||
Comment on attachment 8910685 [details]
Bug 1401917 - Let tab strip scroll buttons use --toolbarbutton-icon-fill-opacity.
Approval Request Comment
[Feature/Bug causing the regression]: photon-visual polish
[User impact if declined]: inconsistent icon opacity
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: let the tab strip overflow and compare that the scroll buttons's opacity to that of other icons
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial isolated fix
[String changes made/needed]: /
Attachment #8910685 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•7 years ago
|
Flags: qe-verify- → qe-verify+
Updated•7 years ago
|
QA Contact: ovidiu.boca
Comment 6•7 years ago
|
||
Comment on attachment 8910685 [details]
Bug 1401917 - Let tab strip scroll buttons use --toolbarbutton-icon-fill-opacity.
Polish photon, taking it.
Should be in 57b3
Attachment #8910685 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 7•7 years ago
|
||
uplift |
Tested on Nightly 58.0a1 Build ID 20170924220116
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:58.0) Gecko/20100101 Firefox/58.0
Inconsistency for scroll buttons's opacity is fixed. I will mark this as Verified Fixed. Thank you
Comment 10•7 years ago
|
||
The inconsistency for scroll button's opacity on Firefox 57.0b9 is now fixed. Marked accordingly.
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•