Closed
Bug 1402065
Opened 7 years ago
Closed 7 years ago
Remove __in and __out from PDFium
Categories
(Firefox :: PDF Viewer, enhancement)
Firefox
PDF Viewer
Tracking
()
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(2 files)
__in, __out, and a variety of related macros (like __in_opt and __in_out) are Microsoft macros that assist in static analysis (they don't do anything besides help static analysis). MinGW defines these to no-ops, but two (__in and __out) cannot be defined in C++ code because they conflict with libstdc++ argument names.
(See line 222 of https://sourceforge.net/p/mingw-w64/mingw-w64/ci/cef07470773f3c56e5189125f6b82bf278265e69/tree/mingw-w64-headers/include/sal.h)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8910908 -
Flags: review?(jwatt)
Attachment #8910909 -
Flags: review?(jwatt)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8910909 [details]
Bug 1402065 Add the pdfium patch to the repo and update.sh
https://reviewboard.mozilla.org/r/182384/#review188432
Attachment #8910909 -
Flags: review?(jwatt) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8910908 [details]
Bug 1402065 Remove __in and __out from our in-tree copy of pdfium
https://reviewboard.mozilla.org/r/182382/#review188434
Attachment #8910908 -
Flags: review?(jwatt) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ec31e5b2ba19
Remove __in and __out from our in-tree copy of pdfium r=jwatt
https://hg.mozilla.org/integration/autoland/rev/0b1d706bd1e5
Add the pdfium patch to the repo and update.sh r=jwatt
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ec31e5b2ba19
https://hg.mozilla.org/mozilla-central/rev/0b1d706bd1e5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in
before you can comment on or make changes to this bug.
Description
•