Closed Bug 1402194 Opened 7 years ago Closed 7 years ago

Pushing to try with no try syntax or try_task_config.json is broken

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla58

People

(Reporter: ahal, Assigned: glandium)

References

Details

Attachments

(1 file)

This may also be related to the busted decision tasks on central, which may be related to sparse checkouts? https://queue.taskcluster.net/v1/task/RX0APNO2Rfa2qPi547QJgQ/runs/0/artifacts/public/logs/live_backing.log [task 2017-09-22T00:05:10.133059Z] Reading file: /builds/worker/checkouts/gecko/layout/moz.build [task 2017-09-22T00:05:10.142359Z] Traceback (most recent call last): [task 2017-09-22T00:05:10.142408Z] File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 154, in taskgraph_decision [task 2017-09-22T00:05:10.142429Z] return taskgraph.decision.taskgraph_decision(options) [task 2017-09-22T00:05:10.142478Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 135, in taskgraph_decision [task 2017-09-22T00:05:10.142504Z] write_artifact('task-graph.json', tgg.morphed_task_graph.to_json()) [task 2017-09-22T00:05:10.142532Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 178, in morphed_task_graph [task 2017-09-22T00:05:10.142556Z] return self._run_until('morphed_task_graph') [task 2017-09-22T00:05:10.142589Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 283, in _run_until [task 2017-09-22T00:05:10.142604Z] k, v = self._run.next() [task 2017-09-22T00:05:10.142628Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 270, in _run [task 2017-09-22T00:05:10.142638Z] do_not_optimize) [task 2017-09-22T00:05:10.142665Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 55, in optimize_task_graph [task 2017-09-22T00:05:10.142680Z] do_not_optimize=do_not_optimize) [task 2017-09-22T00:05:10.142706Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 126, in remove_tasks [task 2017-09-22T00:05:10.142724Z] if opt.should_remove_task(task, params, arg): [task 2017-09-22T00:05:10.142764Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 376, in should_remove_task [task 2017-09-22T00:05:10.142791Z] scheduled = self.scheduled_by_push(params['head_repository'], params['head_rev']) [task 2017-09-22T00:05:10.142817Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py", line 944, in method_call [task 2017-09-22T00:05:10.142833Z] cache[args] = self.func(instance, *args) [task 2017-09-22T00:05:10.142859Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 367, in scheduled_by_push [task 2017-09-22T00:05:10.142875Z] for p, m in rdr.files_info(changed_files).items(): [task 2017-09-22T00:05:10.142902Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1342, in files_info [task 2017-09-22T00:05:10.143044Z] paths, _ = self.read_relevant_mozbuilds(paths) [task 2017-09-22T00:05:10.143775Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1306, in read_relevant_mozbuilds [task 2017-09-22T00:05:10.143824Z] self.config, metadata=metadata): [task 2017-09-22T00:05:10.143924Z] File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1061, in read_mozbuild [task 2017-09-22T00:05:10.143993Z] raise bre [task 2017-09-22T00:05:10.144052Z] BuildReaderError: [task 2017-09-22T00:05:10.144612Z] ============================== [task 2017-09-22T00:05:10.144656Z] ERROR PROCESSING MOZBUILD FILE [task 2017-09-22T00:05:10.144691Z] ============================== [task 2017-09-22T00:05:10.144746Z] [task 2017-09-22T00:05:10.144791Z] The error occurred while processing the following file: [task 2017-09-22T00:05:10.144819Z] [task 2017-09-22T00:05:10.144856Z] /builds/worker/checkouts/gecko/layout/moz.build [task 2017-09-22T00:05:10.144883Z] [task 2017-09-22T00:05:10.145324Z] The error was triggered on line 43 of this file: [task 2017-09-22T00:05:10.145380Z] [task 2017-09-22T00:05:10.145451Z] CRASHTEST_MANIFESTS += ['../testing/crashtest/crashtests.list'] [task 2017-09-22T00:05:10.145481Z] [task 2017-09-22T00:05:10.145531Z] An error was encountered as part of executing the file itself. The error appears to be the fault of the script. [task 2017-09-22T00:05:10.145557Z] [task 2017-09-22T00:05:10.145589Z] The error as reported by Python is: [task 2017-09-22T00:05:10.146181Z] [task 2017-09-22T00:05:10.146222Z] ['ImportError: No module named reftest\n'] [task 2017-09-22T00:05:10.146245Z] [taskcluster 2017-09-22 00:05:10.603Z] === Task Finished === [taskcluster 2017-09-22 00:05:15.886Z] Unsuccessful task run with exit code: 1 completed in 50.127 seconds
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Actually, let's undupe because while comment 1 *was* 1402142, it only masked the fact that pushing to try with no try syntax or try_task_config.json *is* broken, with: [task 2017-09-29T23:00:21.911134Z] Traceback (most recent call last): [task 2017-09-29T23:00:21.911254Z] File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 154, in taskgraph_decision [task 2017-09-29T23:00:21.911346Z] return taskgraph.decision.taskgraph_decision(options) [task 2017-09-29T23:00:21.911446Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 131, in taskgraph_decision [task 2017-09-29T23:00:21.911549Z] write_artifact('target-tasks.json', tgg.target_task_set.tasks.keys()) [task 2017-09-29T23:00:21.911655Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 137, in target_task_set [task 2017-09-29T23:00:21.911746Z] return self._run_until('target_task_set') [task 2017-09-29T23:00:21.911840Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 283, in _run_until [task 2017-09-29T23:00:21.911923Z] k, v = self._run.next() [task 2017-09-29T23:00:21.912020Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 243, in _run [task 2017-09-29T23:00:21.912104Z] target_tasks = set(fltr(target_task_set, self.parameters)) [task 2017-09-29T23:00:21.912207Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/filter_tasks.py", line 35, in filter_target_tasks [task 2017-09-29T23:00:21.912285Z] return fn(graph, parameters) [task 2017-09-29T23:00:21.912377Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/target_tasks.py", line 117, in target_tasks_try [task 2017-09-29T23:00:21.912478Z] return _try_option_syntax(full_task_graph, parameters) [task 2017-09-29T23:00:21.912590Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/target_tasks.py", line 60, in _try_option_syntax [task 2017-09-29T23:00:21.912705Z] options = try_option_syntax.TryOptionSyntax(parameters, full_task_graph) [task 2017-09-29T23:00:21.912820Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/try_option_syntax.py", line 307, in __init__ [task 2017-09-29T23:00:21.912916Z] self.jobs = self.parse_jobs(options['jobs']) [task 2017-09-29T23:00:21.913015Z] TypeError: 'NoneType' object has no attribute '__getitem__' And that is a regression from but 1383880.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee: nobody → mh+mozilla
Comment on attachment 8913893 [details] Bug 1402194 - Don't fail when there is neither try syntax nor try_task_config.json. https://reviewboard.mozilla.org/r/185300/#review190328
Attachment #8913893 - Flags: review?(dustin) → review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/9aa27ded4a4e Don't fail when there is neither try syntax nor try_task_config.json. r=dustin
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: