Closed
Bug 1402234
Opened 7 years ago
Closed 7 years ago
Remove ENABLE_INTL_API=no code from intl/locale
Categories
(Core :: Internationalization, enhancement)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
Part of bug 1308359
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
Rather than the mega-patch here, let's remove various parts of this in separate bugs for the individual functional units; then let's see what (if anything) remains. So holding off on this one for now....
Assignee | ||
Updated•7 years ago
|
Attachment #8911071 -
Flags: review?(jfkthame)
Comment 4•7 years ago
|
||
There are patches in separate bugs (see dependencies of bug 1387332) to handle most of this except for the intl/locale subdirectory. I would suggest morphing this bug to focus just on intl/locale/ and updating the patch accordingly; that'll be a nice clean unit of work to review&land.
Assignee | ||
Updated•7 years ago
|
Summary: Remove ENABLE_INTL_API=no code from intl/ → Remove ENABLE_INTL_API=no code from intl/locale
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
Sounds good! Updated the patch to cover only intl/locale directory.
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8911071 [details]
Bug 1402234 - Remove the ENABLE_INTL_API=no code from intl/locale.
https://reviewboard.mozilla.org/r/182538/#review187886
LGTM, thanks!
Attachment #8911071 -
Flags: review?(jfkthame) → review+
Comment 8•7 years ago
|
||
Well, assuming tryserver is now happy with it, that is. :)
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b47963e73f8
Remove the ENABLE_INTL_API=no code from intl/locale. r=jfkthame
Comment 10•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•