Closed
Bug 1402235
Opened 7 years ago
Closed 7 years ago
Remove ENABLE_INTL_API=no code from js/
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
Part of bug 1308359
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8911084 [details]
Bug 1402235 - Remove the ENABLE_INTL_API=no code from js/.
https://reviewboard.mozilla.org/r/182582/#review187946
Gandalf and I talked about this in-person and agreed to not remove the configure option, at least for now. ICU is a significant part of the compiled code size, and provides functionality that not all embedders will need.
We also agreed that the way the configure option is applied is far from ideal and that something should be done about that.
Attachment #8911084 -
Flags: review?(till) → review-
Comment 3•7 years ago
|
||
I've heard from one embedder that had problems with icu because their main app used the system icu. If he used both, they conflicted. If he did --with-system-icu, the system version was too old for us. So he ended up needing to disable ours. I don't know how common that is.
Assignee | ||
Comment 4•7 years ago
|
||
For now, we decided to not remove the flag from SpiderMonkey
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Comment 5•7 years ago
|
||
bug 1361876 and bug 1346211 will require to have ICU always enabled. And the correct implementation of String.prototype.to[Locale]LowerCase() [1] also requires ICU today. So unless we plan to reimplement the required ICU functionality, we either need to have ENABLE_INTL_API always on or embedders which disable ICU won't get the complete ECMA-262 API.
[1] http://searchfox.org/mozilla-central/rev/15ce5cb2db0c85abbabe39a962b0e697c9ef098f/js/src/jsstr.cpp#759-811
You need to log in
before you can comment on or make changes to this bug.
Description
•