Closed
Bug 1402347
Opened 7 years ago
Closed 7 years ago
Android application time out check is approximate
Categories
(Firefox for Android Graveyard :: Testing, defect)
Firefox for Android Graveyard
Testing
Tracking
(firefox57 fixed, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Android tests fail with "Application ran for longer than allowed maximum time" if the browser runs for too long. This is configured for 90 minutes currently. However, I have seen logs where the browser is running for 100 minutes or more without tripping this time out.
|
Assignee | |
Comment 1•7 years ago
|
||
The existing code has some weaknesses, the worst of which being it does not account for non-sleep time (time reading the log, etc). This should make the check much more accurate.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8690e97abcd192d92b6891865bd3c0afc0976d2
Attachment #8911195 -
Flags: review?(jmaher)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8911195 [details] [diff] [review]
improve accuracy of check for max run time
Review of attachment 8911195 [details] [diff] [review]:
-----------------------------------------------------------------
::: build/mobile/remoteautomation.py
@@ +398,2 @@
> time.sleep(interval)
> timer += interval
do we still need to worry about timer?
Attachment #8911195 -
Flags: review?(jmaher) → review+
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Comment 3•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #2)
> do we still need to worry about timer?
Yes. It's still used for other, shorter-term decisions. I think it makes sense to keep that.
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18028ed94381
Be more exact in Android tests when checking run time; r=jmaher
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Comment 6•7 years ago
|
||
| bugherder uplift | ||
status-firefox57:
--- → fixed
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•