Closed
Bug 1402370
Opened 7 years ago
Closed 7 years ago
Fix GLBlitHelperD3D.cpp to compile under MinGW
Categories
(Core :: Graphics, enhancement, P3)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox57 | --- | unaffected |
firefox58 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor][gfx-noted])
Attachments
(2 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8911229 -
Flags: review?(jmuizelaar)
Attachment #8911230 -
Flags: review?(jmuizelaar)
Updated•7 years ago
|
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8911229 [details]
Bug 1402370 nullptr cannot be cast to bool, so return false instead of nullptr in GLBlitHelperD3D.cpp
https://reviewboard.mozilla.org/r/182718/#review188566
Attachment #8911229 -
Flags: review?(jmuizelaar) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8911230 [details]
Bug 1402370 _uuidof is a Microsoft specific extension while IID_* is a portable solution that will fix the MinGW build of GLBlitHelperD3D.cpp
https://reviewboard.mozilla.org/r/182720/#review188568
Attachment #8911230 -
Flags: review?(jmuizelaar) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/abdad1de090e
nullptr cannot be cast to bool, so return false instead of nullptr in GLBlitHelperD3D.cpp r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/17a1159f7f4d
_uuidof is a Microsoft specific extension while IID_* is a portable solution that will fix the MinGW build of GLBlitHelperD3D.cpp r=jrmuizel
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/abdad1de090e
https://hg.mozilla.org/mozilla-central/rev/17a1159f7f4d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•