Markus Stange [:mstange] Assignee
	Description • 7 years ago

I must have made a mistake when adding -moz-font-smoothing-background-color properties to CSS files in bug 1387594.

Steps to reproduce:
 1. Right click an empty part of the nav-bar, and find the disabled "Pin to Overflow Menu" menu item.
 2. Move your mouse over that disabled menuitem.

Hovering affects the anti-aliasing of the text in that menuitem, even though neither its background color nor its text color change.

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 1 • 7 years ago

Markus, is this slated for uplift to 57 as well?

	Markus Stange [:mstange] Assignee
	Comment 3 • 7 years ago

(In reply to Panos Astithas [:past] (56 Regression Engineering Owner) (please ni?) from comment #1)
> Markus, is this slated for uplift to 57 as well?

Yes, this should be uplifted to 57. It's a very simple, CSS-only patch.

	Dão Gottwald [:dao]
	Comment 4 • 7 years ago
mozreview-review

Comment on attachment 8912837 [details]
Bug 1402416 - Use the correct font smoothing background color for disabled menuitems.

https://reviewboard.mozilla.org/r/184168/#review189666

::: toolkit/themes/osx/global/menu.css:24
(Diff revision 1)
>  
>  menu[disabled="true"], menuitem[disabled="true"],
>  menu[_moz-menuactive="true"][disabled="true"],
>  menuitem[_moz-menuactive="true"][disabled="true"] {
>    color: -moz-mac-menutextdisable;
> +  -moz-font-smoothing-background-color: -moz-mac-menuitem;

Why is this needed? This doesn't seem to cover any element that doesn't already have -moz-font-smoothing-background-color: -moz-mac-menuitem; from the previous rule.

	Markus Stange [:mstange] Assignee
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8912837 [details]
Bug 1402416 - Use the correct font smoothing background color for disabled menuitems.

https://reviewboard.mozilla.org/r/184168/#review189868

::: toolkit/themes/osx/global/menu.css:24
(Diff revision 1)
>  
>  menu[disabled="true"], menuitem[disabled="true"],
>  menu[_moz-menuactive="true"][disabled="true"],
>  menuitem[_moz-menuactive="true"][disabled="true"] {
>    color: -moz-mac-menutextdisable;
> +  -moz-font-smoothing-background-color: -moz-mac-menuitem;

It covers elements that have -moz-font-smoothing-background-color: -moz-mac-active-menuitem; from the menu\[\_moz-menuactive="true"\], menuitem\[\_moz-menuactive="true"\] rule.

	Pulsebot
	Comment 6 • 7 years ago

Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/e365cc4aa8f1
Use the correct font smoothing background color for disabled menuitems. r=dao

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 7 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e365cc4aa8f1

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 7 years ago

Please request Beta approval on this when you get a chance.

	Markus Stange [:mstange] Assignee
	Comment 9 • 7 years ago

Comment on attachment 8912837 [details]
Bug 1402416 - Use the correct font smoothing background color for disabled menuitems.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1387594
[User impact if declined]: small visual glitch when interacting with menus
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: small CSS fix
[String changes made/needed]: none

	Sylvestre Ledru [:Sylvestre]
	Comment 10 • 7 years ago

Comment on attachment 8912837 [details]
Bug 1402416 - Use the correct font smoothing background color for disabled menuitems.

Polish photon, should be in 57b5

	Ryan VanderMeulen [:RyanVM]
	Comment 11 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/d19abce87a20

	ovidiu boca[:Ovidiu]
	Comment 12 • 7 years ago

I verified this issue on Mac OS X 10.10, Windows 7x64 and Windows 10 x64 with FF Nightly 58.0a1(2017-10-18) and FF beta 57.0b9 and I can't reproduce the issue, based on this I will mark this as verified fixed.