Closed
Bug 1402767
Opened 7 years ago
Closed 7 years ago
Enable accleleration of GLScreenBuffer when WebRender is enabled
Categories
(Core :: Graphics: WebRender, defect, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | unaffected |
| firefox58 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
(Whiteboard: [wr-mvp])
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
sotaro
:
review+
|
Details | Diff | Splinter Review |
It is not yet enabled with WebRender.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8911665 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8911666 -
Flags: review?(jgilbert)
|
||
Updated•7 years ago
|
Blocks: stage-wr-nightly
status-firefox57:
--- → unaffected
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [wr-mvp]
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8911666 [details] [diff] [review]
patch - Enable accleleration of GLScreenBuffer when WebRender is enabled
Review of attachment 8911666 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/gl/GLScreenBuffer.cpp
@@ +76,5 @@
> + (backend == layers::LayersBackend::LAYERS_OPENGL ||
> + (backend == layers::LayersBackend::LAYERS_WR && !useANGLE));
> + bool useD3D = !gfxPrefs::WebGLForceLayersReadback() &&
> + (backend == layers::LayersBackend::LAYERS_D3D11 ||
> + (backend == layers::LayersBackend::LAYERS_WR && useANGLE));
I would like these all to be const where possible.
Attachment #8911666 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
Apply the comment.
Attachment #8911666 -
Attachment is obsolete: true
Attachment #8912075 -
Flags: review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1637b28b7f90
Enable accleleration of GLScreenBuffer when WebRender is enabled r=jgilbert
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•