Matthew Gregan [:kinetik] Reporter
	Description • 7 years ago

During the import of bug 1403048, 'mach vendor rust' generated a huge amount of churn due to the .cargo-ok files being deleted and removed from the associated .cargo-checksum.json file.

This seems to have been caused by a change in cargo-vendor 0.1.12 (https://github.com/alexcrichton/cargo-vendor/commit/aa0267a3dd8439b914e6173a7713799ea7790b75) that excludes these files from the vendored source directory.

We should probably make cargo-vendor 0.1.12 the minimum version for 'mach vendor rust' to avoid additional cycles of add/remove churn of these files.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 1 • 7 years ago

When I do the import of bug 1404678, I noticed the same issue. I think we should bump the requirement.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 3 • 7 years ago

Note that, if we do this, we may want to uplift it and do revendor in beta as well, otherwise it could make uplifting some patches involving revendoring more confusing.

Also given that cargo-vendor changes its behavior every now and then, which can cause the result to fluctuate, we probably want to ping a specific version of cargo-vendor somehow, rather than relying on whatever version happens to be installed in the system.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 4 • 7 years ago

I mean, pin a specific version.

	Gregory Szorc [:gps]
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8914048 [details]
Bug 1403407 - Require cargo-vendor 0.1.12 to remove .cargo-ok.

https://reviewboard.mozilla.org/r/185428/#review197290

	Pulsebot
	Comment 6 • 7 years ago

Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94a7d2b657c6
Require cargo-vendor 0.1.12 to remove .cargo-ok. r=gps

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 7 • 7 years ago

This would also need vcs-sync to upgrade its cargo-vendor, I think.

	Xidorn Quan [:xidorn] UTC+11 Assignee
	Comment 8 • 7 years ago

ni? glob for comment 7.

	:glob ✱
	Comment 9 • 7 years ago

thanks xidorn; i've manually reinstalled cargo-vendor, now running v0.1.12

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 10 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/94a7d2b657c6