Closed
Bug 1403459
Opened 7 years ago
Closed 7 years ago
Fix transform 3d/sorting try failures for layers-free
Categories
(Core :: Graphics: WebRender, defect, P1)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | unaffected |
| firefox58 | --- | unaffected |
People
(Reporter: mtseng, Assigned: mtseng)
References
Details
(Whiteboard: [wr-mvp] gfx-noted)
Attachments
(1 file, 1 obsolete file)
Fix fails-if in following tests.
fails-if(webrender) != sorting-1a.html sorting-1-ref.html
fails-if(webrender) == sorting-2a.html sorting-2-ref.html
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
|
Assignee | |
Comment 1•7 years ago
|
||
I have a gecko patch for this. However, webrender had some bugs for handling 3d transform. I'll fix webrender first.
|
||
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•7 years ago
|
||
Also need webrender fix. The PR is here https://github.com/servo/webrender/pull/1787
The try combined gecko and webrender patch is here.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=958197010292b196df56583fe54a7d6cb7fbbf3f&selectedJob=136157668
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8917663 [details]
Bug 1403459 - Passing transform-style from display item directly.
https://reviewboard.mozilla.org/r/188606/#review194000
Attachment #8917663 -
Flags: review?(bugmail) → review+
|
|
||
Updated•7 years ago
|
Depends on: 1407213
See Also: → https://github.com/servo/webrender/pull/1787
|
|
Assignee | |
Comment 5•7 years ago
|
||
kats, since webrender PR has been merged. Would you mind land this patch along with next webrender update? Thanks.
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(bugmail)
|
|
||
Comment 7•7 years ago
|
||
Two of the reftests that this patch marked as passing are from the WR update, so I moved those reftest.list changes into bug 1407213. I'll rebase this patch on top of those patches and land it after the WR update.
| Comment hidden (mozreview-request) |
|
|
||
Comment 9•7 years ago
|
||
Comment on attachment 8917663 [details]
Bug 1403459 - Passing transform-style from display item directly.
Obsoleting the old patch
Attachment #8917663 -
Attachment is obsolete: true
|
|
||
Comment 10•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8918391 [details]
Bug 1403459 - Passing transform-style from display item directly.
https://reviewboard.mozilla.org/r/189210/#review194492
Attachment #8918391 -
Flags: review?(bugmail) → review+
|
||
Comment 11•7 years ago
|
||
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74a760610fd0
Passing transform-style from display item directly. r=kats
|
||
Comment 12•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•